Skip to content

[v2] Exclude hidden files from example folder during test file collection #9539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

rakshil14-2
Copy link

@rakshil14-2 rakshil14-2 commented Jun 9, 2025

This is the port of CLI v1 of #9530

Description of changes:
Tests cases were failing for the users who use Mac Finder that creates hidden system files such as .DS_Store or ._command-name.rst in the directory. Thus, when the test suite is running, it fails because it encounters a unwanted files in the examples folder that has not a .rst or .txt extension.

Resolution
System-generated files like .DS_Store and other hidden files like .command-name.rst are starting with . followed by the file name, hence while gathering all the files having extension other than .rst file, the files starting with . were ignored, making the test suite free from hidden files.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rakshil14-2 rakshil14-2 marked this pull request as ready for review June 10, 2025 15:15
@kdaily kdaily changed the title Exclude hidden files from example folder during test file collection [v2] Exclude hidden files from example folder during test file collection Jun 10, 2025
@kdaily kdaily merged commit 01a3e85 into aws:v2 Jun 10, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants