Skip to content

fix: make paginated tables fit terminal dimensions - #1896

Open
aidandaly24 wants to merge 2 commits into
refactorfrom
fix/data-table-content-height
Open

fix: make paginated tables fit terminal dimensions#1896
aidandaly24 wants to merge 2 commits into
refactorfrom
fix/data-table-content-height

Conversation

@aidandaly24

@aidandaly24 aidandaly24 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • render the DataTable filter prompt in the existing divider row so filtering does not change table height
  • increase the terminal-derived page size by one so full paginated tables reach the footer
  • make Runtime Version and Harness Version tables fill the available terminal width
  • keep footer hints on one row by switching to compact key-only hints when labels do not fit
  • cover all production table width configurations and the paginated 60x24 layout with regressions

Testing

  • bun test src (587 pass, 0 fail)
  • focused DataTable and pagination tests (27 pass, 0 fail)
  • source-scoped TypeScript check excluding ignored generated dist assets
  • bun run lint:check
  • bun run format:check
  • bun run build
  • live Runtime Version and Harness Version validation at 120x32
  • live paginated Runtime List validation at 60x24

@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 3, 2026
@codecov-commenter

codecov-commenter commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.01%. Comparing base (ec57799) to head (dc72fb1).

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #1896   +/-   ##
=========================================
  Coverage     96.01%   96.01%           
=========================================
  Files           211      211           
  Lines          9837     9844    +7     
=========================================
+ Hits           9445     9452    +7     
  Misses          392      392           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 3, 2026
@aidandaly24 aidandaly24 changed the title fix: fill paginated tables to footer fix: make paginated tables fit terminal dimensions Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants