Refactor buf modules #4083
Open
Refactor buf modules #4083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
commented
Jul 14, 2025
| @@ -131,7 +131,7 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| - uses: bufbuild/buf-action@dfda68eacb65895184c76b9ae522b977636a2c47 #v1.1.4 | |||
| with: | |||
| input: "proto" | |||
There was a problem hiding this comment.
Upon making changes to our CI I think there was a miss and we need another github action to run the linter on the connect module as a follow-up to this.
There was a problem hiding this comment.
Is there a way to not use a github action for a new linter? Ideally this one should go away in favor of a task that can be executed both locally and in CI.
There was a problem hiding this comment.
Hm - I'm being dumb... our check-generate-protobuf nix task which is already in ci runs linting under the connectproto directory already (which also does run locally).
It's actually unclear to me what this CI step is for - since it doesn't push the buf schema and just runs the linter.
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
requested review from
rrazvan1,
maru-ava,
meaghanfitzgerald and
StephenButtolph
as code owners
|
Coreth branch: ava-labs/coreth#1047 |
maru-ava
approved these changes
Jul 14, 2025
mpignatelli12
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We compile our buf modules seprately since the
protomodule doesn't want to compile stuff with theconnectplugin. This PR puts our buf modules under a common directory instead of separateprotoandconnectprotodirectories.How this works
Moves files
How this was tested
CI
Need to be documented in RELEASES.md?
No