Skip to content

[antithesis] Enable reuse of banff e2e test for antithesis testing #3554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 21, 2025
Merged

[antithesis] Enable reuse of banff e2e test for antithesis testing #3554

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
27c090a
[antithesis] Enable reuse of banff e2e test for antithesis testing
maru-ava Sep 19, 2024
5398a55
fixup: Fix lint failure
maru-ava Dec 4, 2024
b53c1ab
fixup: Update load test
maru-ava Jun 25, 2025
e669feb
fixup: self-review
maru-ava Jun 25, 2025
d9f5ded
fixup: disable banff execution pending #4049
maru-ava Jul 2, 2025
74d9ec3
Update tests/antithesis/context.go
maru-ava Jul 2, 2025
9052d5f
fixup: Respond to review feedback
maru-ava Jul 2, 2025
95b5937
fixup: Add RecoverAndRethrow as per review feedback
maru-ava Jul 3, 2025
21b742c
fixup: Add panic recovery to load2
maru-ava Jul 21, 2025
be47f02
fixup: Ensure text context is canceled immediately
maru-ava Jul 21, 2025
4ba0379
fixup: Ensure GetDefaultParentContext returns a non-nil context
maru-ava Jul 21, 2025
0077c8f
fixup: Revert change making it non-fatal to fail to read randomness
maru-ava Jul 21, 2025
af08e65
fixup: Cleanup context usage as per review comment
maru-ava Jul 23, 2025
58674de
fixup: Ensure sleep case is reachable
maru-ava Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions tests/load2/generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,7 @@ func (l LoadGenerator) Run(
default:
}

ctx, cancel := context.WithTimeout(ctx, testTimeout)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to execTestWithRecovery to ensure that cancelation is localized to test execution rather than only being performed on goroutine exit.

defer cancel()

execTestWithRecovery(ctx, log, l.test, l.wallets[i])
execTestWithRecovery(ctx, log, l.test, l.wallets[i], testTimeout)
}
})
}
Expand All @@ -98,8 +95,10 @@ func (l LoadGenerator) Run(

// execTestWithRecovery ensures assertion-related panics encountered during test execution are recovered
// and that deferred cleanups are always executed before returning.
func execTestWithRecovery(ctx context.Context, log logging.Logger, test Test, wallet *Wallet) {
func execTestWithRecovery(ctx context.Context, log logging.Logger, test Test, wallet *Wallet, testTimeout time.Duration) {
tc := tests.NewTestContext(log)
Copy link
Contributor

@maru-ava maru-ava Jul 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a new TestContext here ensures that recovery executes only the cleanups registered to this context.

defer tc.Recover()
test.Run(tc, ctx, wallet)
contextWithTimeout, cancel := context.WithTimeout(ctx, testTimeout)
defer cancel()
test.Run(tc, contextWithTimeout, wallet)
}