[antithesis] Enable reuse of banff e2e test for antithesis testing

[marun]

Why this should be merged

Having to duplicate existing test coverage to benefit from execution with antithesis is not ideal. Better to be able to trivially refactor compatible e2e coverage for reuse. This PR refactors the banff e2e test for reuse with antithesis to demonstrate that this is possible.

How this works

• adds new APITestFunction type that a compatible e2e test can implement to allow for execution with both ginkgo and antithesis
• adds ExecuteAPITest helper to simplify execution of an APITestFunction with ginkgo
• Refactors the banff e2e test into an APITestFunction executed by ExecuteAPITest
• Refactors the avalanchego antithesis test setup to support execution of the banff test
  • Moves test dispatch into a new function so that panics can be recovered via a deferred function
    • This supports use of require by e2e tests without risking an unhandled panic exiting the test process

How this was tested

CI

Need to be documented in RELEASES.md?

N/A

[marun]

Switched to draft in light of wanting to rebase on #3557

[marun]

Moving to draft and adding a bunch of TODOs prompted by a manually-triggered antithesis run. The error handling of the e2e test is not sufficiently robust, so there are a lot of unhelpful errors that need to be addressed before this PR will be mergeable.

[github-actions]

This PR has become stale because it has been open for 30 days with no activity. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

[github-actions]

This PR has become stale because it has been open for 30 days with no activity. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

[maru-ava]

Approving my own PR is a treat (because my personal account proposed it), but I'll hold off on merging until someone else approves.

[maru-ava]

Creating a new TestContext here ensures that recovery executes only the cleanups registered to this context.

[maru-ava]

Moved to execTestWithRecovery to ensure that cancelation is localized to test execution rather than only being performed on goroutine exit.

[RodrigoVillar]

Nit: since the test will now gracefully recover in the case of a context cancellation, we should modify the following:

avalanchego/tests/load2/generator.go

Lines 71 to 76 in 8a1bd2a

	childCtx := ctx
	if loadTimeout != 0 {
	ctx, cancel := context.WithTimeout(ctx, loadTimeout)
	childCtx = ctx
	defer cancel()
	}

to just:

if loadTimeout != 0 {
    childCtx, cancel := context.WithTimeout(ctx, loadTimeout)
    ctx = childCtx
    defer cancel()
}

This way, Run() only deals with just one context which is easier to read + having two separate contexts isn't necessary as a result of this PR.

[maru-ava]

This way, Run() only deals with just one context which is easier to read + having two separate contexts isn't necessary as a result of this PR.

Done

[maru-ava]

I'd like to rename SimpleTestContext to RecoverableTestContext, but would prefer to do that in a follow-on PR.

[StephenButtolph]

A couple minor comments / questions. Feel free to merge after resolving.