Skip to content

chore: split toolchain registration in root module to prod & dev#933

Merged
gregmagolan merged 1 commit intomainfrom
cleanup_toolchains
Apr 10, 2026
Merged

chore: split toolchain registration in root module to prod & dev#933
gregmagolan merged 1 commit intomainfrom
cleanup_toolchains

Conversation

@gregmagolan
Copy link
Copy Markdown
Member

@gregmagolan gregmagolan commented Apr 9, 2026

No description provided.

@aspect-workflows
Copy link
Copy Markdown

aspect-workflows bot commented Apr 10, 2026

Bazel 8 (Test)

All tests were cache hits

113 tests (100.0%) were fully cached saving 53s.


Bazel 9 (Test)

All tests were cache hits

112 tests (100.0%) were fully cached saving 1m.


Bazel 8 (Test)

e2e

All tests were cache hits

52 tests (100.0%) were fully cached saving 45s.


Bazel 9 (Test)

e2e

All tests were cache hits

52 tests (100.0%) were fully cached saving 42s.


Bazel 8 (Test)

examples/uv_pip_compile

All tests were cache hits

1 test (100.0%) was fully cached saving 444ms.


Buildifier

@gregmagolan gregmagolan changed the title chore: remove redundant toolchain registration in root module chore: split toolchain registration in root module to prod & dev Apr 10, 2026
@gregmagolan gregmagolan marked this pull request as ready for review April 10, 2026 01:39
@gregmagolan gregmagolan requested review from CaerusKaru, acozzette, jbedard and xangcastle and removed request for CaerusKaru April 10, 2026 01:39
@gregmagolan gregmagolan enabled auto-merge (squash) April 10, 2026 01:45
Copy link
Copy Markdown
Member

@jbedard jbedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, assuming e2e tests are verifying this correctly 🤞

@gregmagolan gregmagolan merged commit 9dabd27 into main Apr 10, 2026
3 checks passed
@gregmagolan gregmagolan deleted the cleanup_toolchains branch April 10, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants