Revert "Add option to skip the dryrun from the sync context (#708)" #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#708)" This reverts commit 717b8bf. Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #730 +/- ##
==========================================
- Coverage 54.26% 53.74% -0.53%
==========================================
Files 64 64
Lines 6164 6475 +311
==========================================
+ Hits 3345 3480 +135
- Misses 2549 2722 +173
- Partials 270 273 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
agaudreault
approved these changes
Jun 5, 2025
This was referenced Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed my mind and now think this is more of a hatchet solution than the scalpel we need to solve argoproj/argo-cd#21788.
Disabling dry runs entirely means you completely lose validation indefinitely. That's an aggressive solution to a problem that likely only presents itself once in the lifecycle of an app.
Talked with @agaudreault, and we think we can solve the problem with a lighter touch.
This change hasn't been released in any Argo CD version yet, so it's safe to revert.
@alexmt since you merged the PR initially, lmk if you'd like to discuss further!