-
Notifications
You must be signed in to change notification settings - Fork 284
Feature skip dryrun in all cases #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature skip dryrun in all cases #728
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
==========================================
- Coverage 54.26% 53.80% -0.46%
==========================================
Files 64 64
Lines 6164 6486 +322
==========================================
+ Hits 3345 3490 +145
- Misses 2549 2724 +175
- Partials 270 272 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…resource type is known Signed-off-by: Nick Heijmink <[email protected]>
Signed-off-by: Nick Heijmink <[email protected]>
Signed-off-by: Nick Heijmink <[email protected]>
Signed-off-by: Nick Heijmink <[email protected]>
Signed-off-by: Nick Heijmink <[email protected]>
Signed-off-by: Nick Heijmink <[email protected]>
Signed-off-by: Nick Heijmink <[email protected]>
Signed-off-by: Nick Heijmink <[email protected]>
4c243ef
to
13f10ff
Compare
|
if agreed on the change we can squash or I can create a new branch |
Closing due to #730 Will be replace by creating the namespace before the DryRun if the namespace does not exist. Eventually, a new option should be added to perform the dry run on the current wave instead of on all the resource before the sync. |
sounds like a good alternative |
@agaudreault I did create something like that in the past: |
This is an extention to solve the issue that the validation fails on creating resources in a not yet existing namespace.
argoproj/argo-cd#21788
and a followup to:
#708
By setting the skipDryRun you can skip the validation in your sync action allowing the resources that can already be created (the namespace) to be created and the other resources in another sync wave.
In the old situation it only worked for CRD's which made it redundant to skipDryRunOnMissingResource. By moving it out of the err!=nil check it can be used by all type of resources.
If oke I will join the meeting next thursday to explain the requested change.