Skip to content

Feature skip dryrun in all cases #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Nheijmink19
Copy link
Contributor

This is an extention to solve the issue that the validation fails on creating resources in a not yet existing namespace.
argoproj/argo-cd#21788
and a followup to:
#708

By setting the skipDryRun you can skip the validation in your sync action allowing the resources that can already be created (the namespace) to be created and the other resources in another sync wave.
In the old situation it only worked for CRD's which made it redundant to skipDryRunOnMissingResource. By moving it out of the err!=nil check it can be used by all type of resources.

If oke I will join the meeting next thursday to explain the requested change.

@Nheijmink19 Nheijmink19 requested a review from a team as a code owner June 4, 2025 12:37
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.80%. Comparing base (8849c3f) to head (13f10ff).
Report is 47 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
- Coverage   54.26%   53.80%   -0.46%     
==========================================
  Files          64       64              
  Lines        6164     6486     +322     
==========================================
+ Hits         3345     3490     +145     
- Misses       2549     2724     +175     
- Partials      270      272       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Nheijmink19 Nheijmink19 force-pushed the feature-skip-dryrun-in-all-cases branch from 4c243ef to 13f10ff Compare June 4, 2025 14:46
Copy link

sonarqubecloud bot commented Jun 4, 2025

@Nheijmink19
Copy link
Contributor Author

if agreed on the change we can squash or I can create a new branch

@agaudreault
Copy link
Member

Closing due to #730

Will be replace by creating the namespace before the DryRun if the namespace does not exist.

Eventually, a new option should be added to perform the dry run on the current wave instead of on all the resource before the sync.

@agaudreault agaudreault closed this Jun 6, 2025
@Nheijmink19
Copy link
Contributor Author

sounds like a good alternative

@Nheijmink19
Copy link
Contributor Author

@agaudreault I did create something like that in the past:
https://github.com/argoproj/gitops-engine/pull/664/files
I am not sure if my implementation is the way you planned on building it, but if it is you already have a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants