Skip to content

[SPARK-54536][CORE] Shuffle FetchWaitTime missing collect create client/wait cost #53245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AngersZhuuuu wants to merge 7 commits into from
Closed

[SPARK-54536][CORE] Shuffle FetchWaitTime missing collect create client/wait cost #53245

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
04dff7e
[SPARK-54536[CORE] Shuffle FetchWaitTime missing first call fetchUpTo…
AngersZhuuuu Nov 27, 2025
23eebd9
Update ShuffleBlockFetcherIterator.scala
AngersZhuuuu Dec 2, 2025
0ab5fac
Update ShuffleBlockFetcherIterator.scala
AngersZhuuuu Dec 2, 2025
800fb9a
Update ShuffleBlockFetcherIterator.scala
AngersZhuuuu Dec 2, 2025
3643026
Update ShuffleBlockFetcherIterator.scala
AngersZhuuuu Dec 2, 2025
1a761e5
Follow comment
AngersZhuuuu Dec 3, 2025
56061b6
Merge branch 'master' into SPARK-54536
AngersZhuuuu Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,7 @@ final class ShuffleBlockFetcherIterator(
", expected bytesInFlight = 0 but found bytesInFlight = " + bytesInFlight)

// Send out initial requests for blocks, up to our maxBytesInFlight
val startFetchWait = System.nanoTime()
fetchUpToMaxBytes()

val numDeferredRequest = deferredFetchRequests.values.map(_.size).sum
Expand All @@ -733,6 +734,8 @@ final class ShuffleBlockFetcherIterator(
// Get host local blocks if any
fetchAllHostLocalBlocks(hostLocalBlocksByExecutor)
pushBasedFetchHelper.fetchAllPushMergedLocalBlocks(pushMergedLocalBlocks)
val fetchWaitTime = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startFetchWait)
shuffleMetrics.incFetchWaitTime(fetchWaitTime)
Copy link
Contributor

@cloud-fan cloud-fan Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this metric is never updated before?

Copy link
Contributor Author

@AngersZhuuuu AngersZhuuuu Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discuss, change to like this.

}

private def fetchAllHostLocalBlocks(
Expand Down