[SPARK-54536][CORE] Shuffle FetchWaitTime missing collect create client/wait cost #53245
+12
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MaxBytes() open block rpc response time
Contributor
Author
|
gentle ping @cloud-fan @holdenk Could you take a look? |
cloud-fan
reviewed
Nov 28, 2025
| fetchAllHostLocalBlocks(hostLocalBlocksByExecutor) | ||
| pushBasedFetchHelper.fetchAllPushMergedLocalBlocks(pushMergedLocalBlocks) | ||
| val fetchWaitTime = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startFetchWait) | ||
| shuffleMetrics.incFetchWaitTime(fetchWaitTime) |
Contributor
There was a problem hiding this comment.
so this metric is never updated before?
Contributor
Author
There was a problem hiding this comment.
As discuss, change to like this.
Contributor
|
Please clearly describe the problem. How is shuffle fetch wait time calculated today and why it's inaccurate. |
Contributor
Author
Add more explain in the pr desc, pls take a look |
cloud-fan
reviewed
Dec 2, 2025
|
|
||
| initialize() | ||
|
|
||
| private def incFetchWaitTime[T](f: () => T): Unit = { |
Contributor
There was a problem hiding this comment.
Suggested change
| private def incFetchWaitTime[T](f: () => T): Unit = { | |
| private def withFetchWaitTimeTracked[T](f: => T): Unit = { |
cloud-fan
reviewed
Dec 2, 2025
| val t = f() | ||
| val fetchWaitTime = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startFetchWait) | ||
| shuffleMetrics.incFetchWaitTime(fetchWaitTime) | ||
| return t |
Contributor
There was a problem hiding this comment.
Suggested change
| return t | |
| t |
cloud-fan
reviewed
Dec 2, 2025
|
|
||
| private def incFetchWaitTime[T](f: () => T): Unit = { | ||
| val startFetchWait = System.nanoTime() | ||
| val t = f() |
Contributor
There was a problem hiding this comment.
Suggested change
| val t = f() | |
| val res = f() |
AngersZhuuuu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When ShuffleBlockFetcherIterator fetch data, two shuffle cost not calculated.
fetchUpToMaxBytesandfetchAllHostLocalBlocks;fetchUpToMaxBytesandfetchAllHostLocalBlockssend request, create client may be congestionWhy are the changes needed?
Make shuffle fetch wait time request time more accurate.
Does this PR introduce any user-facing change?
No
How was this patch tested?
For open block request add a Thread.sleep(3000) latency, shuffle read metrics like below
Was this patch authored or co-authored using generative AI tooling?
No