Skip to content

REFACTOR: Scheduler logic #6399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 17, 2025
Merged

REFACTOR: Scheduler logic #6399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c6e2e3b
REFACTOR: Split scheduler logic and add checks
SMoraisAnsys Jul 14, 2025
106af52
FIX: Typo in template / class
SMoraisAnsys Jul 14, 2025
bd82201
chore: adding changelog file 6398.miscellaneous.md [dependabot-skip]
pyansys-ci-bot Jul 14, 2025
ff72b64
chore: adding changelog file 6399.miscellaneous.md [dependabot-skip]
pyansys-ci-bot Jul 14, 2025
a789201
REFACTOR: Update naming and default values
SMoraisAnsys Jul 15, 2025
2fada93
DOCS: Add docstrings on properties and mark class
SMoraisAnsys Jul 17, 2025
2838c6b
FIX: Update attribute names
SMoraisAnsys Jul 17, 2025
f495e54
FIX: Consistency checker and ram per core setter
SMoraisAnsys Jul 17, 2025
aa86fee
REFACTOR: Remove TOML due to None values
SMoraisAnsys Jul 17, 2025
bf6fc29
TESTS: Extend testing
SMoraisAnsys Jul 17, 2025
bdc8e1b
TESTS: Fix settings tests
SMoraisAnsys Jul 17, 2025
438aac2
TESTS: Fix AREG tests
SMoraisAnsys Jul 17, 2025
24ba749
FIX: Default values in pyaedt settings YAML file
SMoraisAnsys Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/6398.miscellaneous.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Scheduler logic
1 change: 1 addition & 0 deletions doc/changelog.d/6399.miscellaneous.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Scheduler logic
4 changes: 2 additions & 2 deletions doc/source/Resources/pyaedt_settings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@ log:
# Settings related to Linux systems running LSF scheduler
lsf:
# Command to launch in the LSF Scheduler
custom_lsf_command: null
custom_lsf_command: ''
# Command to launch the task in the LSF Scheduler
lsf_aedt_command: 'ansysedt'
# Number of LSF cores
lsf_num_cores: 2
lsf_num_cores: 4
# Operating system string
lsf_osrel: null
# LSF queue name
Expand Down
709 changes: 596 additions & 113 deletions src/ansys/aedt/core/generic/scheduler.py
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/ansys/aedt/core/generic/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@
"remote_rpc_session_temp_folder",
"block_figure_plot",
"skip_license_check",
"num_cores",
]
ALLOWED_AEDT_ENV_VAR_SETTINGS = [
"ANSYSEM_FEATURE_F335896_MECHANICAL_STRUCTURAL_SOLN_TYPE_ENABLE",
Expand Down
8 changes: 4 additions & 4 deletions src/ansys/aedt/core/misc/Job_Settings_Template.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ $begin 'AddEntries'
\ \ \ \ NumCoresPerDistributedTask={{cores_per_task}}\
\ \ \ \ LimitTasksPerNodeEnabled=false\
\ \ \ \ NumMaxTasksPerNode={{max_tasks_per_node}}\
\ \ \ \ NumGpus={{num_gpu}}\
\ \ \ \ NumGpus={{num_gpus}}\
\ \ \ $end \'TasksAndCoresBlock\'\
\ \ \ $begin \'RAMConstrainedBlock\'\
\ \ \ \ IsExclusive=false\
Expand All @@ -35,7 +35,7 @@ $begin 'AddEntries'
\ \ \ \ RAMLimit={{ram_limit}}\
\ \ \ \ NumNodes={{num_nodes}}\
\ \ \ \ NumCores={{num_cores}}\
\ \ \ \ NumGpus={{num_gpu}}\
\ \ \ \ NumGpus={{num_gpus}}\
\ \ \ $end \'NodesAndCoresBlock\'\
\ \ \ $begin \'NodeListBlock\'\
\ \ \ \ $begin \'MachineListVec\'\
Expand Down Expand Up @@ -64,8 +64,8 @@ $begin 'AddEntries'
\ \ \ OverwriteFiles=false\
\ \ $end \'ArchiveOptions\'\
\ \ $begin \'SharedDirectories\'\
\ \ \ WindowsPaths[0:]\
\ \ \ LinuxPaths[0:]\
\ \ \ WindowsPaths[{{shared_directory_windows}}]\
\ \ \ LinuxPaths[{{shared_directory_linux}}]\
\ \ $end \'SharedDirectories\'\
\ \ $begin \'MultiStepJobSettings\'\
\ \ \ SelectedOption=\'\'\
Expand Down
Loading