-
Notifications
You must be signed in to change notification settings - Fork 165
REFACTOR: Scheduler logic #6399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR: Scheduler logic #6399
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with minor suggestions:
- Please revert to "num" for variables with "number" names.
- Great to have all of the validation logic!
- Will add more tests to check behavior when this is merged.
@Devin-Crawford I've removed my implementation of loading/exporting from/into TOML as we work with |
@Devin-Crawford The refactoring is performed and tests should be passing. We can merge if that's fine with you. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/6316_submit_job_interface #6399 +/- ##
=================================================================
Coverage ? 85.29%
=================================================================
Files ? 174
Lines ? 65691
Branches ? 0
=================================================================
Hits ? 56033
Misses ? 9658
Partials ? 0 🚀 New features to boost your workflow:
|
7bb63ea
into
feat/6316_submit_job_interface
Co-authored-by: pyansys-ci-bot <[email protected]>
Description
The main idea is to split the submission attributes into two classes. On for the resources where there are a few checks performed and adjustement performed if needed (only triggered when writting the AREG file). If the user provided non aligned values, the class raises an exception when trying to write the AREG file.
Issue linked
Related to #6316
Checklist