Skip to content

REFACTOR: Scheduler logic #6399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SMoraisAnsys
Copy link
Collaborator

Description

The main idea is to split the submission attributes into two classes. On for the resources where there are a few checks performed and adjustement performed if needed (only triggered when writting the AREG file). If the user provided non aligned values, the class raises an exception when trying to write the AREG file.

Issue linked

Related to #6316

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner July 14, 2025 07:52
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys SMoraisAnsys requested review from Devin-Crawford and removed request for a team July 14, 2025 07:52
Copy link
Contributor

@Devin-Crawford Devin-Crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with minor suggestions:

  • Please revert to "num" for variables with "number" names.
  • Great to have all of the validation logic!
  • Will add more tests to check behavior when this is merged.

@SMoraisAnsys
Copy link
Collaborator Author

SMoraisAnsys commented Jul 17, 2025

@Devin-Crawford I've removed my implementation of loading/exporting from/into TOML as we work with None values and this format is not handling this value.

@SMoraisAnsys
Copy link
Collaborator Author

@Devin-Crawford The refactoring is performed and tests should be passing. We can merge if that's fine with you.
@MaxJPRey Thanks for the review ;)

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 98.31650% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/6316_submit_job_interface@b94e163). Learn more about missing BASE report.

Additional details and impacted files
@@                        Coverage Diff                        @@
##             feat/6316_submit_job_interface    #6399   +/-   ##
=================================================================
  Coverage                                  ?   85.29%           
=================================================================
  Files                                     ?      174           
  Lines                                     ?    65691           
  Branches                                  ?        0           
=================================================================
  Hits                                      ?    56033           
  Misses                                    ?     9658           
  Partials                                  ?        0           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys SMoraisAnsys self-assigned this Jul 17, 2025
@Samuelopez-ansys Samuelopez-ansys merged commit 7bb63ea into feat/6316_submit_job_interface Jul 17, 2025
37 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the refactor/scheduler-logic branch July 17, 2025 13:53
SMoraisAnsys added a commit that referenced this pull request Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants