-
Notifications
You must be signed in to change notification settings - Fork 173
FEAT: Support new EmitCom API for 25R2, add node classes for all EMIT node types #6068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
121 commits
Select commit
Hold shift + click to select a range
935d091
EMIT API branch
jsalant22 f14755b
Add first draft of generated nodes and basic interface
bryankaylor 4aef45e
New version of generated nodes
bryankaylor 3cce1c1
Updated generated nodes and interface
bryankaylor 04c4218
Add generated module init file, update EmitNode
bryankaylor 3f33e2a
Add node functions for getting children
bryankaylor bfef0cf
Update generated nodes spacing and add_ methods, move NodeInterface m…
bryankaylor 3aac82f
Add equality operator to EmitNode class
bryankaylor 70100fd
Remove equality operator from generated nodes
bryankaylor 84f6c32
update revision and result classes for api changes
jsalant22 5d0ece1
Merge branch 'F932911' of https://github.com/ansys/pyaedt into F932911
jsalant22 68034da
use display names for access nodes
jsalant22 fcee90c
add units support
jsalant22 c280da2
fix unit parsing
jsalant22 32060dd
Add updated generated nodes, fix emit allowed unit names, fix emit de…
bryankaylor 6a06ab5
Fix revision constructor for 252, fix units
bryankaylor 5501be5
Update results and revision modules to use new result API
bryankaylor 0633784
Revert change of GetKeptResultProperties to GetResultProperties
bryankaylor f5b5780
Add EmitterBand and TxSpectralProfEmitter classes (#6048)
jsalant22 5a01894
Add test for generated nodes
bryankaylor 55bb89d
Fix merge conflict
bryankaylor 726e6d4
Add warning for disconnected comps (#6056)
jsalant22 4b68e24
F1251272 (#6063)
jsalant22 95189be
Add dynamic generated node test
bryankaylor 39fd586
Fix conflict
bryankaylor 98d0248
Fix merge conflicts for files deleted in main
bryankaylor 5fba8f8
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 4c74e09
chore: adding changelog file 6068.added.md [dependabot-skip]
pyansys-ci-bot 16d567f
Re-delete readded files
bryankaylor 05e89d9
Merge branch 'F932911' of ssh://ssh.github.com:443/ansys/pyaedt into …
bryankaylor 69224b2
Remove unused TestClass member
bryankaylor d3aa753
Fix duplicate method in EmitNode, change dynamic test to run all methods
bryankaylor c0da9c1
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 80138a3
Support loading Kept results, return ReadOnly nodes for Kept results,…
bryankaylor 1a57448
Merge branch 'F932911' of ssh://ssh.github.com:443/ansys/pyaedt into …
bryankaylor a9f347d
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] f173855
Merge branch 'main' into F932911
jsalant22 393bb29
style changes
jsalant22 fdf0c3f
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] df07da7
more style fixes
jsalant22 e3faed0
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] ca0c268
add enum imports
jsalant22 b7e4e8f
Merge branch 'F932911' of https://github.com/ansys/pyaedt into F932911
jsalant22 420ed94
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] b21517c
use pyaedt decorator
jsalant22 2ee9f3f
Merge branch 'F932911' of https://github.com/ansys/pyaedt into F932911
jsalant22 f86bdd1
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] b28c667
style fixes
jsalant22 5d43d9a
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 3a1485e
fix method names
jsalant22 b4d064c
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] a552d44
revert min version check
jsalant22 7e0158b
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 358dbc8
move decorator out of class
jsalant22 b967b2f
remove unused import
jsalant22 fa4f58b
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 6d1ed2d
fix some units code
jsalant22 7dd7750
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] a829dc8
skip lint
jsalant22 d146173
replace id with node_id
jsalant22 0d71e22
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] e37b217
change solver to use 25.2
jsalant22 a0f00d9
chore: adding changelog file 6068.added.md [dependabot-skip]
pyansys-ci-bot 1f11dcc
Merge branch 'main' into F932911
jsalant22 a3e5e87
Support component rename in EmitNode.rename, update all generated cla…
bryankaylor cfc3001
Merge branch 'F932911' of ssh://ssh.github.com:443/ansys/pyaedt into …
bryankaylor faf5ea8
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 6e98c38
Remove some unused topLevelNode access
jsalant22 bb8e556
Update revision.py
jsalant22 ab349b3
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 9759502
Fix EMIT tests for 252
bryankaylor 6582562
Merge branch 'F932911' of ssh://ssh.github.com:443/ansys/pyaedt into …
bryankaylor 6c766ff
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 901d7f0
Reuse current result, remove irrelevant block from revision generatio…
bryankaylor a494595
Fix 25R1 tests
bryankaylor 087da75
Re-add get/set units to EMIT object
bryankaylor 0e7bec6
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] ca9dae1
Fix version check in Enum initialization
bryankaylor 0c0a481
Merge branch 'main' into F932911
SMoraisAnsys c2d6b33
CHORE: Add nosec B105 where needed
SMoraisAnsys e8b675c
address PR comments
jsalant22 75dbed9
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] ca17091
remove lint comments
jsalant22 42b3098
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 2f03278
Use absolute imports, use common AEDT major version guard decorator, …
bryankaylor 17c3fe2
Remove test file
bryankaylor 72efa75
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] dcb38aa
Update src/ansys/aedt/core/emit_core/emit_constants.py
bryankaylor a30cbbb
Fix all docstrings in generated EMIT classes
bryankaylor ec05d69
Fix power unit in radio_component test
bryankaylor 2a1ac4f
update bool get/set
jsalant22 ffc6350
Update docstring parsing for min/max, use EmitNode._get_property and …
bryankaylor e6dfc24
Merge branch 'F932911' of https://github.com/ansys/pyaedt into F932911
bryankaylor a47aa15
Call each node property for multiple configurations of each node, fix…
bryankaylor 8719175
Comment out testing of kept result nodes
bryankaylor 0242871
Remove read_only versions of nodes, and stop constructing them
bryankaylor 050b945
Merge branch 'main' into F932911
bryankaylor b25d529
chore: adding changelog file 6068.added.md [dependabot-skip]
pyansys-ci-bot 2bc73f5
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 25ddd62
Not skip test in 2025R2
Samuelopez-ansys 36535fe
Test both getter and setter if setter fails
bryankaylor 247fec4
Merge branch 'F932911' of https://github.com/ansys/pyaedt into F932911
bryankaylor 297be00
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 5db53c8
Fix units, dont skip test 23b
bryankaylor 80f48f3
Merge branch 'F932911' of https://github.com/ansys/pyaedt into F932911
bryankaylor ecf7111
Fix all codacy issues
bryankaylor 1ca0c8b
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] c923dac
Remove duplicate result cat test
bryankaylor 93cdf48
Renumber test, record exceptions when adding child nodes
bryankaylor 6dc02fb
Merge branch 'F932911' of https://github.com/ansys/pyaedt into F932911
bryankaylor 929ac5c
CHORE: Auto fixes from pre-commit hooks
pre-commit-ci[bot] 5f86428
Merge branch 'main' into F932911
Samuelopez-ansys ebe07c1
Merge branch 'main' into F932911
Samuelopez-ansys bbf9314
Fix pre-commit
Samuelopez-ansys 432c91d
Fix documentation
Samuelopez-ansys afbc02a
Revert default version
Samuelopez-ansys eab3558
Merge branch 'main' into F932911
Samuelopez-ansys 4e70d1c
Update src/ansys/aedt/core/emit_core/nodes/emit_node.py
bryankaylor 1c4b1f0
Update src/ansys/aedt/core/emit_core/nodes/emit_node.py
bryankaylor b9b0863
Update src/ansys/aedt/core/emit_core/results/revision.py
bryankaylor 1314509
Fix comments when managing current result
bryankaylor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Support new emitcom api for 25r2, add node classes for all emit node types |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.