Skip to content

FEAT: Support new EmitCom API for 25R2, add node classes for all EMIT node types #6068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 112 commits into
base: main
Choose a base branch
from
Open

FEAT: Support new EmitCom API for 25R2, add node classes for all EMIT node types #6068

wants to merge 112 commits into from

Conversation

bryankaylor
Copy link
Contributor

Description

Updates the Revision class to use the new EmitCom API for accessing results and manipulating the EMIT project using EMIT nodes.

Issue linked

TFS Story F932911

Checklist

  • I have tested my changes locally.
  • [] I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

jsalant22 and others added 25 commits January 22, 2025 10:13
@jsalant22
EMIT API branch
935d091 
Reconfigure Revision class for some API changes
@bryankaylor
Add first draft of generated nodes and basic interface
f14755b
@bryankaylor
New version of generated nodes
4aef45e
@bryankaylor
Updated generated nodes and interface
3cce1c1
@bryankaylor
Add generated module init file, update EmitNode
04c4218
@bryankaylor
Add node functions for getting children
3f33e2a
@bryankaylor
Update generated nodes spacing and add_ methods, move NodeInterface m…
bfef0cf 
…ethods to Revision and make revision-aware, add methods for getting individual top level nodes
@bryankaylor
Add equality operator to EmitNode class
3aac82f
@bryankaylor
Remove equality operator from generated nodes
70100fd
@jsalant22
update revision and result classes for api changes
84f6c32 
Update the revision/result classes to support new api
@jsalant22
Merge branch 'F932911' of https://github.com/ansys/pyaedt into F932911
5d0ece1
@jsalant22
use display names for access nodes
68034da 
use display names for access nodes
@jsalant22
add units support
fcee90c 
add units support
@jsalant22
fix unit parsing
c280da2 
fix conversion from string to decimal+string
@bryankaylor
Add updated generated nodes, fix emit allowed unit names, fix emit de…
32060dd 
…fault units
@bryankaylor
Fix revision constructor for 252, fix units
6a06ab5
@bryankaylor
Update results and revision modules to use new result API
5501be5
@bryankaylor
Revert change of GetKeptResultProperties to GetResultProperties
0633784
@jsalant22 @pre-commit-ci
Add EmitterBand and TxSpectralProfEmitter classes (#6048)
f5b5780 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@bryankaylor
Add test for generated nodes
5a01894
@bryankaylor
Fix merge conflict
55bb89d
@jsalant22 @pre-commit-ci
Add warning for disconnected comps (#6056)
726e6d4 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@jsalant22
F1251272 (#6063)
4b68e24
@bryankaylor
Add dynamic generated node test
95189be
@bryankaylor
Fix conflict
39fd586
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

pre-commit-ci bot and others added 13 commits May 21, 2025 20:21
@pre-commit-ci
CHORE: Auto fixes from pre-commit hooks
72efa75
@bryankaylor @SMoraisAnsys
Update src/ansys/aedt/core/emit_core/emit_constants.py
dcb38aa 
Co-authored-by: Sébastien Morais <[email protected]>
@bryankaylor
Fix all docstrings in generated EMIT classes
a30cbbb
@bryankaylor
Fix power unit in radio_component test
ec05d69
@jsalant22
update bool get/set
2a1ac4f 
Fix antenna_node
@bryankaylor
Update docstring parsing for min/max, use EmitNode._get_property and …
ffc6350 
…EmitNode._set_property functions in generated code, improve exception messages from properties, fix some missing add functions, remove some generated headers
@bryankaylor
Merge branch 'F932911' of https://github.com/ansys/pyaedt into F932911
e6dfc24
@bryankaylor
Call each node property for multiple configurations of each node, fix…
a47aa15 
… setting bool values in generated code
@bryankaylor
Comment out testing of kept result nodes
8719175
@bryankaylor
Remove read_only versions of nodes, and stop constructing them
0242871
@bryankaylor
Merge branch 'main' into F932911
050b945
@pyansys-ci-bot
chore: adding changelog file 6068.added.md [dependabot-skip]
b25d529
@pre-commit-ci
CHORE: Auto fixes from pre-commit hooks
2bc73f5
@bryankaylor
Copy link
Contributor Author

@SMoraisAnsys @Samuelopez-ansys - We've made some improvements to this PR by removing a lot of the generated code and improving our solver unit test to improve coverage. Now, when run locally with 25R2, the coverage of the new src\ansys\aedt\core\emit_core\nodes\generated folder is 78.45%. Could we get another review of this PR? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsalant22 jsalant22 jsalant22 approved these changes

@myoung301 myoung301 Awaiting requested review from myoung301

@SMoraisAnsys SMoraisAnsys Awaiting requested review from SMoraisAnsys

@Samuelopez-ansys Samuelopez-ansys Awaiting requested review from Samuelopez-ansys

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New features or code improvements testing Anything related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bryankaylor @jsalant22 @Samuelopez-ansys @SMoraisAnsys @pyansys-ci-bot