Skip to content

fix: patch rather than sleep for time sensitive pytest #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

fix: patch rather than sleep for time sensitive pytest #1344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions tests/unit/test_application_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import time
import datetime
from unittest.mock import Mock, patch

import pytest
Expand Down Expand Up @@ -124,15 +124,27 @@ def test_read_remote_setting(eda_caplog):
},
]

with patch("aap_eda.analytics.utils.requests.get") as mock_get:
now = datetime.datetime(2025, 1, 1, 0, 0)
now_effect = [
now,
now + datetime.timedelta(milliseconds=100),
now + datetime.timedelta(milliseconds=200),
now + datetime.timedelta(milliseconds=300),
now + datetime.timedelta(milliseconds=1400),
now + datetime.timedelta(milliseconds=1500),
]

with (
patch("django.utils.timezone.now", side_effect=now_effect),
patch("aap_eda.analytics.utils.requests.get") as mock_get,
):
mock_get.return_value = mock_resp
assert application_settings.AUTOMATION_ANALYTICS_GATHER_INTERVAL == 500
assert application_settings.REDHAT_USERNAME == "foo"
# repeat within interval
assert application_settings.AUTOMATION_ANALYTICS_GATHER_INTERVAL == 500
assert application_settings.REDHAT_USERNAME == "foo"

time.sleep(1)
# repeat after interval
assert (
application_settings.AUTOMATION_ANALYTICS_GATHER_INTERVAL == 1000
Expand Down