Skip to content

fix(markdown): skip redundant href in conceal mode for autolinks #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mocksoul wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(markdown): skip redundant href in conceal mode for autolinks #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bf871b
fix(markdown): skip redundant href in conceal mode for autolinks
mocksoul Feb 19, 2026
59995cd
test: update snapshot for incomplete link after conceal fix
mocksoul Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/core/src/renderables/Markdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,14 @@ export class MarkdownRenderable extends Renderable {
for (const child of token.tokens) {
this.renderInlineTokenWithStyle(child as MarkedToken, chunks, "markup.link.label", linkHref)
}
chunks.push(this.createChunk(" (", "markup.link", linkHref))
chunks.push(this.createChunk(token.href, "markup.link.url", linkHref))
chunks.push(this.createChunk(")", "markup.link", linkHref))
// Only show (href) suffix when label text differs from the URL itself
// (autolinks and bare URLs have label === href, so showing both is redundant)
const labelText = token.tokens.map((t: { raw: string }) => t.raw).join("")
if (labelText !== token.href) {
chunks.push(this.createChunk(" (", "markup.link", linkHref))
chunks.push(this.createChunk(token.href, "markup.link.url", linkHref))
chunks.push(this.createChunk(")", "markup.link", linkHref))
}
} else {
chunks.push(this.createChunk("[", "markup.link", linkHref))
for (const child of token.tokens) {
Expand Down
3 changes: 1 addition & 2 deletions packages/core/src/renderables/__tests__/Markdown.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,8 +984,7 @@ test("incomplete link (no closing paren)", async () => {

expect(await renderMarkdown(markdown)).toMatchInlineSnapshot(`
"
Check out [this link](https://example.com (https://example.
com)"
Check out [this link](https://example.com"
`)
})

Expand Down
Loading