fix(markdown): skip redundant href in conceal mode for autolinks#707
Open
mocksoul wants to merge 2 commits intoanomalyco:mainfrom
Open
fix(markdown): skip redundant href in conceal mode for autolinks#707mocksoul wants to merge 2 commits intoanomalyco:mainfrom
mocksoul wants to merge 2 commits intoanomalyco:mainfrom
Conversation
When conceal mode renders a link where the label text equals the href (e.g. bare URLs and autolinks), the URL was shown twice: `https://example.com (https://example.com)` Now only shows `https://example.com` when label matches href. Named links like `[docs](https://example.com)` still show as `docs (https://example.com)`.
mocksoul
requested review from
Hona,
kommander,
msmps and
simonklee
as code owners
@opentui/core
@opentui/react
@opentui/solid
@opentui/core-darwin-arm64
@opentui/core-darwin-x64
@opentui/core-linux-arm64
@opentui/core-linux-x64
@opentui/core-win32-arm64
@opentui/core-win32-x64
commit: |
Collaborator
|
Is this still relevant with recent refactors? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When conceal mode renders a link where the label text equals the href (e.g. bare URLs and autolinks), the URL was displayed twice:
This adds a check to skip the
(href)suffix when the label matches the URL. Named links like[docs](https://example.com)still render asdocs (https://example.com).