qos: update QoS version#162
Conversation
|
Hi @Turnalek, thank you for your contribution! It looks like this is your first time contributing. To get this PR merged, please review our Contributor License Agreement (CLA) here: https://ironcladapp.com/public-launch/6896309b0f158de8c7450de6 Once you have reviewed the agreement, a maintainer (@anchorageoss/maintainers) will need to approve your addition to our contributors list by commenting |
r-n-o
left a comment
r-n-o
left a comment
There was a problem hiding this comment.
We should probably wait to see a successful Turnkey release (scheduled for tomorrow) before we merge this, but otherwise looks great to me!
Goodbye copy/pasted host code 👋
Turnalek
force-pushed
the
ales/qos_channels_update
branch
from
453a332 to
25f7eaa
Compare
|
Hi @Turnalek, thank you for your contribution! It looks like this is your first time contributing. To get this PR merged, please review our Contributor License Agreement (CLA) here: https://ironcladapp.com/public-launch/6896309b0f158de8c7450de6 Once you have reviewed the agreement, a maintainer (@anchorageoss/maintainers) will need to approve your addition to our contributors list by commenting |
Turnalek
force-pushed
the
ales/qos_channels_update
branch
from
25f7eaa to
9fdbfc8
Compare
|
Hi @Turnalek, thank you for your contribution! It looks like this is your first time contributing. To get this PR merged, please review our Contributor License Agreement (CLA) here: https://ironcladapp.com/public-launch/6896309b0f158de8c7450de6 Once you have reviewed the agreement, a maintainer (@anchorageoss/maintainers) will need to approve your addition to our contributors list by commenting |
Turnalek
force-pushed
the
ales/qos_channels_update
branch
from
9fdbfc8 to
19fc412
Compare
|
Hi @Turnalek, thank you for your contribution! It looks like this is your first time contributing. To get this PR merged, please review our Contributor License Agreement (CLA) here: https://ironcladapp.com/public-launch/6896309b0f158de8c7450de6 Once you have reviewed the agreement, a maintainer (@anchorageoss/maintainers) will need to approve your addition to our contributors list by commenting |
|
/approve-cla |
Approved by: @prasanna-anchorage Related PR: #162
|
✅ @Turnalek has been added to a new CLA signers batch PR # by @prasanna-anchorage. The CLA check will pass once the batch PR is merged. |
Approved by: @prasanna-anchorage Related PR: #162
* chore: Add @Turnalek to CLA signers list Approved by: @prasanna-anchorage Related PR: #162 * Move Turnalek under r-n-o in Turnkey section 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Halasy <luke.halasy@anchorlabs.com> Co-authored-by: Claude <noreply@anthropic.com>
|
should be good to merge now after a rebase or upstream merge |
this includes a major refactor to use the new TCP bridge: 1. move parser/host functionality into parser/app 2. directly call QosParserRequest/Response in the new apphost 3. remove unused enclave health endpoint (use port 3001/http direct for that) 4. clean up integration tests and remove simulator_enclave
Turnalek
force-pushed
the
ales/qos_channels_update
branch
from
19fc412 to
d8e2c03
Compare
* chore: Add @Turnalek to CLA signers list Approved by: @prasanna-anchorage Related PR: #162 * Move Turnalek under r-n-o in Turnkey section 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Halasy <luke.halasy@anchorlabs.com> Co-authored-by: Claude <noreply@anthropic.com>
3 participants
this includes a major refactor to use the new TCP bridge:
NOTE: this will require infrastructure deployment changes to remove the unused host and provide the pivot args of host-ip and port