Skip to content

feat(vue): update routing examples #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

francoischalifour
Copy link
Contributor

@francoischalifour francoischalifour commented Jun 14, 2019

This updates the routing Vue InstantSearch examples with a better URL schemas and more consistency with the other flavor examples. These examples will be the base of the new Routing URLs guide.

I renamed the examples because they were completely different from the other flavors.

SEO URL Changes

Before

https://website.com/?menu[categories]=Cell Phones&refinementList[brand][0]=Apple&refinementList[brand][1]=Samsung&page=2&query=galaxy

After

https://website.com/Phones/?q=galaxy&p=2&brands=Apple|Samsung

Preview

Related

  • algolia/doc#3344

@francoischalifour francoischalifour requested a review from a team June 14, 2019 13:01
@Haroenv
Copy link
Contributor

Haroenv commented Jun 24, 2019

for SEO routing, you're adding the url path search to all URLs, but this isn't the path on which the file is served by default, which is somewhat confusing when it shows that url once you interact

For the Vue Router example, it seems like something went wrong with the dynamic import, it works fine if I change it to remove the lazy loading, which isn't really necessary in an example anyway.

Screenshot 2019-06-24 at 10 37 38

https://codesandbox.io/s/routing-vue-router-48blx

All other changes are 👌

@francoischalifour
Copy link
Contributor Author

  1. This is also the behavior in other flavor implementations but it was approved. Do you have a quick solution in mind that could work for all flavors?

  2. I'm not sure to understand, how did you get this error?

@Haroenv
Copy link
Contributor

Haroenv commented Jun 27, 2019

  1. I guess it's no big deal, but a solution like for the main Nuxt example could work: https://codesandbox.io/s/github/algolia/vue-instantsearch/tree/master/examples/nuxt

  2. It's not happening anymore, but was just on the default sandbox you linked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants