Skip to content

feat(vue): update SEO-friendly routing #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

yannickcr
Copy link

This updates the SEO-friendly routing Vue InstantSearch example with a more appropriate URL schema. This example will be the base of the new Routing URLs guide.

URL Changes

Before

# Encoded
https://website.com/?menu%5Bcategories%5D=Cell%20Phones&refinementList%5Bbrand%5D%5B0%5D=Apple&refinementList%5Bbrand%5D%5B1%5D=Samsung&query=galaxy=Samsung&page=2&query=galaxy
# Decoded
https://website.com/?menu[categories]=Cell Phones&refinementList[brand][0]=Apple&refinementList[brand][1]=Samsung&page=2&query=galaxy

After

# Encoded
https://website.com/Cell-Phones/?q=galaxy&p=2&brands=Apple%7CSamsung
# Decoded
https://website.com/Cell-Phones/?q=galaxy&p=2&brands=Apple|Samsung

Preview

Try it live →

@yannickcr yannickcr requested review from tkrugg and Haroenv June 26, 2019 13:50
@francoischalifour
Copy link
Contributor

Huh, there was a misunderstanding. The code samples changes were already addressed in #129. Only the documentation guide is to be updated.

@yannickcr
Copy link
Author

Oh, ok. I will take directly the new code samples for the guide then.

@yannickcr yannickcr closed this Jun 26, 2019
@yannickcr yannickcr deleted the feat/vue-routing branch June 26, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants