Repository navigation
Add Samsung TV client to default extraction - #145
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 36 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be6267180a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let ytcfg = try await ytcfg | ||
|
|
||
| let innertubeClients: [InnerTube.ClientType] = [.visionOS, .web] | ||
| let innertubeClients: [InnerTube.ClientType] = [.tvSamsung, .visionOS, .web] |
There was a problem hiding this comment.
Filter DRM streams before prioritizing Samsung
When YouTube returns drmFamilies on formats for the Samsung TV client, these streams require a DRM license and cannot be played through the current Stream API. StreamingData.Format does not decode or filter that marker, and because this client is now first, the itag deduplication at lines 268–272 retains its DRM URL while discarding a usable response with the same itag from visionOS or web. Filter DRM-marked formats before deduplication (or otherwise ensure a non-DRM response wins), or affected sessions will receive apparently valid but unplayable streams.
Useful? React with 👍 / 👎.
| let ytcfg = try await ytcfg | ||
|
|
||
| let innertubeClients: [InnerTube.ClientType] = [.visionOS, .web] | ||
| let innertubeClients: [InnerTube.ClientType] = [.tvSamsung, .visionOS, .web] |
There was a problem hiding this comment.
Keep spherical variants when prioritizing Samsung
For 360° videos, the Samsung TV profile can return a flat viewport variant for an itag whose spherical/equirectangular variant is returned by another client. Since Samsung is now first and streams deduplicates solely by itag at lines 268–272, its URL wins and the correctly projected variant from visionOS or web is discarded, causing VR/360 consumers to receive the wrong projection. Avoid prioritizing Samsung for these videos, or decode projectionType and account for it during selection and deduplication.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit be62671. Configure here.
| let ytcfg = try await ytcfg | ||
|
|
||
| let innertubeClients: [InnerTube.ClientType] = [.visionOS, .web] | ||
| let innertubeClients: [InnerTube.ClientType] = [.tvSamsung, .visionOS, .web] |
There was a problem hiding this comment.
DRM formats override playable streams
Medium Severity
Prioritizing tvSamsung can replace playable streams from visionOS and web. That client is known to return DRM-protected HTTPS formats, and those still win the per-itag merge because nothing inspects drmFamilies. Playback then fails for itags that the other clients already provided as clear streams.
Reviewed by Cursor Bugbot for commit be62671. Configure here.


Note
Overview Adds Samsung TV to default video extraction through
tvSamsung, queried concurrently alongside the existingvisionOSandwebclients.Samsung TV client Introduces a
TVHTML5profile with client version5.20260707, a Samsung Smart TV user agent, and device metadata identifying a SamsungUKS9800running Tizen2.4.0.