Skip to content

Use Safari user agent for embedded playback - #146

Merged
alexeichhorn merged 1 commit into
feature/samsung-tv-clientfrom
fix/embedded-safari-user-agent
Oct 24, 2026
Merged

alexeichhorn merged 1 commit into
feature/samsung-tv-clientfrom
fix/embedded-safari-user-agent

Conversation

@alexeichhorn

@alexeichhorn alexeichhorn commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner
  • Problem: The embedded fallback lacks the Safari user agent used by yt-dlp to expose additional HLS formats.
  • Solution: Set that user agent on the existing embedded client.

Note

Overview Embedded playback now uses an explicit Safari user agent for the WEB_EMBEDDED_PLAYER client.

Client configuration ClientType.webEmbed replaces its unset userAgent with a string identifying Safari 15.5 on macOS 10.15.7, including the gzip(gfe) suffix.

@alexeichhorn
alexeichhorn added this pull request to stack #148 October 23, 2026 17:16
@alexeichhorn
alexeichhorn marked this pull request as ready for review October 23, 2026 17:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T17:42:47.870338Z aedf62a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d07a0a33-1f7c-4e5b-9623-68ba72dcd8cd
📥 Commits

Reviewing files that changed from the base of the PR and between be62671 and aedf62a.

📒 Files selected for processing: 1
  • Sources/YouTubeKit/InnerTube.swift

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

The .webEmbed client now sets a Safari user-agent string. The generated headers include this value.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to aedf6

No actionable merge-blocking risk remains for this focused change.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: using a Safari user agent for embedded playback.
Description check Passed The description directly explains the embedded playback problem and the Safari user-agent solution.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alexeichhorn
alexeichhorn merged commit 89854c9 into main Oct 24, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant