Mostly working 1.6 version #30
Conversation
_mono_assembly was moved from System.Reflection.Assembly to System.Reflection.RuntimeAssembly in mono. Change the type name fixes fatal error during 1.6 startup. Commit here: Unity-Technologies/mono@e14ef8a#diff-4b6f98b8749e45ca2b4ac71c214bdcf41918c832be851cbb18d244b1d62153fe
|
Shouldn't the About.xml be updated? And add a 1.6 folder? |
move old assemblies to 1.5 folder compile assemblies for 1.6 copy new 0Harmony.dll
bump implementation version
|
Can anyone confirm that FreePatching outside of Prepatcher, i.e., not the WorldCamera fixes embedded within, is indeed working? |
Definitely works for me, checked with both dumping assembly and walking through prepatched assemblies with doorstop(without hotreload)+dnspy |
|
Sorry, just to clarify - you've tested a 3rd party mod utilizing FreePatching and it was successfully able to boot into the game? I'm asking this because I'm running into issues with Prepatcher changing my assemblies to reflect-only before invoking my free patch methods throwing a System.InvalidOperationException. I'm not sure if the issue was on my end or if Prepatcher might not be working for 3rd party patches yet (i.e., patches not embedded within Prepatcher itself). |
|
I have a personal mod - not prepatcher itself - running both FreePatch and FreePatchAll and both are working properly. Also Prepatcher only sets old assemblies to refonly after all freepatches/injections etc were executed so prepatcher itself shouldn't be the cause of any refonly errors during freepatching. |
|
@jikulopo is this PR description still up-to-date, or have issues like PDB loading since been fixed? |
Description is up to date - assemblies modified by mono.cecil no longer match the original pdb files and |
… to load Allow creation of pdb from prepatched assemlies
|
Pdb generation now implemented |
Update PrepatcherModId to match the actual mod id
… old modId, fix prestarter breaking on empty modlist
…more correct vanilla took; pass logs from before restart
7 participants
Replaced 0harmony.dll from harmonyMod
contains changes from #29
fixed worldCameraDriver beeing null after prepatcher recreates components
freepatching/injections are working as far as i can tell
downside: loss of PDB lines in log