fix: use effective default reviewers for bitbucket cloud#18467
Open
subnix wants to merge 3 commits intoWeblateOrg:mainfrom
Open
fix: use effective default reviewers for bitbucket cloud#18467subnix wants to merge 3 commits intoWeblateOrg:mainfrom
subnix wants to merge 3 commits intoWeblateOrg:mainfrom
Conversation
Bitbucket Cloud has a hierarchical system of settings: workspace -> project -> repository. Some settings, like default reviewers, may be configured at a project level and inherited by a repository. Thus, we should use [effective default reviewers](https://developer.atlassian.com/cloud/bitbucket/rest/api-group-pullrequests/#api-repositories-workspace-repo-slug-effective-default-reviewers-get) to obtain reviewers for a pull request.
|
Member
|
Can you please adjust tests to the changed behavior? Won't it break existing configurations? |
Author
Done
This change should be backward compatible since the required privileges remain the same, and default reviewers are only used for PR creation. I've tested this on a local instance and it works fine. Additionally, I've added some defensive code to safeguard against potential response parsing issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bitbucket Cloud has a hierarchical system of settings: workspace -> project -> repository. Some settings, like default reviewers, may be configured at a project level and inherited by a repository. Thus, we should use effective default reviewers to obtain reviewers for a pull request.