-
Notifications
You must be signed in to change notification settings - Fork 15
Fix unnatural Japanese translations #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
meow-meooow
wants to merge
2
commits into
Web3Auth:main
Choose a base branch
from
meow-meooow:fix/localization-japanese
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -113,7 +113,7 @@ | |
| "english": "Continue with a wallet", | ||
| "french": "Continuer avec un portefeuille", | ||
| "german": "Fahren Sie mit einer Brieftasche fort", | ||
| "japanese": "ウォレットを続ける", | ||
| "japanese": "ウォレットで続行", | ||
| "korean": "지갑으로 계속하기", | ||
| "mandarin": "继续使用钱包", | ||
| "portuguese": "Continuar com uma carteira", | ||
|
|
@@ -125,7 +125,7 @@ | |
| "english": "Don't see your wallet?", | ||
| "french": "Vous ne voyez pas votre portefeuille ?", | ||
| "german": "Sie sehen Ihr Portemonnaie nicht?", | ||
| "japanese": "財布が見えませんか?", | ||
| "japanese": "ウォレットがありませんか?", | ||
| "korean": "지갑이 보이지 않나요?", | ||
| "mandarin": "没看到你的钱包吗?", | ||
| "portuguese": "Não vê sua carteira?", | ||
|
|
@@ -161,7 +161,7 @@ | |
| "english": "Continue with external wallet", | ||
| "french": "Continuer avec le portefeuille externe", | ||
| "german": "Fahren Sie mit der externen Wallet fort", | ||
| "japanese": "外部ウォレットを続行する", | ||
| "japanese": "外部ウォレットで続行する", | ||
| "korean": "외부 지갑으로 계속하기", | ||
| "mandarin": "继续使用外部钱包", | ||
| "portuguese": "Continuar com carteira externa", | ||
|
|
@@ -173,7 +173,7 @@ | |
| "english": "Continue with {{wallet}}", | ||
| "french": "Continuer avec {{wallet}}", | ||
| "german": "Fahren Sie mit {{wallet}} fort", | ||
| "japanese": "{{wallet}}を続けます", | ||
| "japanese": "{{wallet}}で続行", | ||
| "korean": "{{wallet}}로 계속하기", | ||
| "mandarin": "继续使用{{wallet}}", | ||
| "portuguese": "Continue com o {{wallet}}", | ||
|
|
@@ -363,7 +363,7 @@ | |
| "english": "Self-custody via", | ||
| "french": "Auto-cuir via", | ||
| "german": "Selbstversorgung über", | ||
| "japanese": "経由の自立", | ||
| "japanese": "自己保管ログイン by", | ||
| "korean": "셀프 커스터디", | ||
| "mandarin": "自我castody通过", | ||
| "portuguese": "Autoconfiança via", | ||
|
|
@@ -699,7 +699,7 @@ | |
| "english": "Continue with", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @shahbaz17 Can you also please help me with more context for this string?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| "french": "Continuer avec", | ||
| "german": "Weitermachen mit", | ||
| "japanese": "続ける", | ||
| "japanese": "で続行", | ||
| "korean": "계속하기", | ||
| "mandarin": "继续", | ||
| "portuguese": "Continuar com", | ||
|
|
@@ -711,7 +711,7 @@ | |
| "english": "Continue with {{adapter}}", | ||
| "french": "Continuer avec {{adapter}}", | ||
| "german": "Fahren Sie mit {{adapter}} fort", | ||
| "japanese": "{{adapter}}を続けます", | ||
| "japanese": "{{adapter}}で続行", | ||
| "korean": "{{adapter}}로 계속하기", | ||
| "mandarin": "继续使用{{adapter}}", | ||
| "portuguese": "Continue com o {{adapter}}", | ||
|
|
@@ -759,7 +759,7 @@ | |
| "english": "Continue", | ||
| "french": "Continuer", | ||
| "german": "Weitermachen", | ||
| "japanese": "続ける", | ||
| "japanese": "続行", | ||
| "korean": "계속", | ||
| "mandarin": "继续", | ||
| "portuguese": "Continuar", | ||
|
|
@@ -867,7 +867,7 @@ | |
| "english": "View less", | ||
| "french": "Voir moins", | ||
| "german": "Weniger anzeigen", | ||
| "japanese": "表示が少なくなります", | ||
| "japanese": "表示を減らす", | ||
| "korean": "간략히 보기", | ||
| "mandarin": "少查看", | ||
| "portuguese": "Ver menos", | ||
|
|
@@ -879,7 +879,7 @@ | |
| "english": "View less socials", | ||
| "french": "Voir moins socials", | ||
| "german": "Weniger anzeigen socials", | ||
| "japanese": "表示を減らす socials", | ||
| "japanese": "Socials の表示を減らす", | ||
| "korean": "Socials 간략히 보기", | ||
| "mandarin": "查看更少socials", | ||
| "portuguese": "Ver menos socials", | ||
|
|
@@ -903,7 +903,7 @@ | |
| "english": "View more socials", | ||
| "french": "Voir plus socials", | ||
| "german": "Weitere socials anzeigen", | ||
| "japanese": "もっと見る socials", | ||
| "japanese": "Socials をもっと見る", | ||
| "korean": "Socials 더보기", | ||
| "mandarin": "查看更多socials", | ||
| "portuguese": "Ver mais socials", | ||
|
|
@@ -1169,7 +1169,7 @@ | |
| "english": "You have reached the limit for wrong attempts. Please restart the flow again to complete verification.", | ||
| "french": "Vous avez atteint la limite pour les tentatives erronées. Veuillez redémarrer le flux pour terminer la vérification.", | ||
| "german": "Sie haben die Grenze für falsche Versuche erreicht. Bitte starten Sie den Fluss erneut neu, um die Überprüfung abzuschließen.", | ||
| "japanese": "間違った試みの制限に達しました。確認を完了するには、フローをもう一度再起動してください。", | ||
| "japanese": "エラー回数の制限に達しました。確認を完了するには、フローをもう一度再起動してください。", | ||
| "korean": "잘못된 시도 횟수를 초과했습니다. 인증을 완료하려면 절차를 다시 시작해 주세요.", | ||
| "mandarin": "您已经达到了错误的尝试的极限。请再次重新启动流程以完成验证。", | ||
| "portuguese": "Você atingiu o limite para tentativas erradas. Reinicie o fluxo novamente para concluir a verificação.", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shahbaz17 Can you tell me what this full string might say, please? The Japanese linguist is confused what would come after "Self-custody via..". Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used in the previous versions to show
"Self-custody via Web3Auth"