fix: migrate conformance tests to UCP SDK v0.3.0#32
Open
sbeashwar wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Open
fix: migrate conformance tests to UCP SDK v0.3.0#32sbeashwar wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
sbeashwar wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This was referenced Apr 17, 2026
sbeashwar
force-pushed
the
pr1-sdk-migration
branch
from
5e84307 to
7135fdf
Compare
5 tasks
sbeashwar
force-pushed
the
pr1-sdk-migration
branch
2 times, most recently
from
a8e9a0d to
975b3be
Compare
SDK v0.3.0 renamed and restructured all model modules: - UcpDiscoveryProfile deleted; use BusinessSchema from ucp.schemas.ucp - *_resp modules renamed to base names (fulfillment_resp -> checkout) - *_req modules renamed to *_request with matching class names - Payment models moved to top-level payment.py - Fulfillment models restructured with new required fields - Service discovery uses flat transport model with ReverseDomainName keys Test fixes: - All 13 test files updated for new import paths and class names - FulfillmentMethodCreateRequest: pass line_item_ids=[] (optional on create per spec, but SDK marks required) - Fulfillment response access converted from typed attributes to dict subscript (extra="allow" models) - Payment instrument construction standardized via get_valid_payment_payload() - Protocol test version assertions updated for 2026-01-23 Result: 57/59 pass (2 simulation_secret config mismatches, not SDK issues)
sbeashwar
force-pushed
the
pr1-sdk-migration
branch
from
975b3be to
fa87acd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates all 13 conformance test files to work with UCP SDK v0.3.0, which renamed and restructured all model modules.
Without this change, the conformance suite cannot import the SDK and all tests fail with
ModuleNotFoundError.Changes
UcpDiscoveryProfilereplaced withBusinessSchemafromucp_sdk.models.schemas.ucp*_respmodules renamed to base names (e.g.,fulfillment_resp->checkout)*_reqmodules renamed to*_requestwith updated class namespayment.pyextra="allow"modelsReverseDomainNamekeysFulfillmentMethodCreateRequest: passline_item_ids=[](optional on create per spec, required by SDK model)get_valid_payment_payload()Test results
53/53 pass against Flower Shop server on 2026-01-23 profile.
Type of change
Checklist