fix: validate payment handler structure from profile instead of hardcoded list#33
Open
sbeashwar wants to merge 2 commits intoUniversal-Commerce-Protocol:mainfrom
Open
fix: validate payment handler structure from profile instead of hardcoded list#33sbeashwar wants to merge 2 commits intoUniversal-Commerce-Protocol:mainfrom
sbeashwar wants to merge 2 commits intoUniversal-Commerce-Protocol:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This was referenced Apr 17, 2026
sbeashwar
force-pushed
the
pr2-handler-validation
branch
from
9437117 to
4e07e22
Compare
5 tasks
sbeashwar
force-pushed
the
pr2-handler-validation
branch
2 times, most recently
from
ab4c86f to
0fdda07
Compare
SDK v0.3.0 renamed and restructured all model modules: - UcpDiscoveryProfile deleted; use BusinessSchema from ucp.schemas.ucp - *_resp modules renamed to base names (fulfillment_resp -> checkout) - *_req modules renamed to *_request with matching class names - Payment models moved to top-level payment.py - Fulfillment models restructured with new required fields - Service discovery uses flat transport model with ReverseDomainName keys Test fixes: - All 13 test files updated for new import paths and class names - FulfillmentMethodCreateRequest: pass line_item_ids=[] (optional on create per spec, but SDK marks required) - Fulfillment response access converted from typed attributes to dict subscript (extra="allow" models) - Payment instrument construction standardized via get_valid_payment_payload() - Protocol test version assertions updated for 2026-01-23 Result: 57/59 pass (2 simulation_secret config mismatches, not SDK issues)
…oded list Replace hardcoded expected handler IDs (google_pay, mock_payment_handler, shop_pay) with structural validation that: - Discovers handlers from the business profile dynamically - Validates required fields (id, version) are present - Validates handler group names follow reverse-DNS convention - Works against any UCP merchant, not just the Flower Shop This makes the protocol conformance tests server-agnostic.
sbeashwar
force-pushed
the
pr2-handler-validation
branch
from
0fdda07 to
ad6639e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces hardcoded expected handler IDs (
google_pay,mock_payment_handler,shop_pay) inprotocol_test.pywith structural validation that discovers handlers from the business profile.The current test assumes the Flower Shop's specific handlers are present, which means any non-Flower-Shop merchant fails the protocol conformance test. This change makes the test server-agnostic.
Changes
id,version) are present on each handlerDepends on
Type of change
Checklist