Enhanced max slew fixing to remove large unfixed violations #8870
+2,799
−2,399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Added extra step to fix slew violations at load pins 2) Used actual slews from STA if possible, not just lumped RC estimates 3) Fixed a bug that led to overfixing due to wrong driver selection after buffering Signed-off-by: Cho Moon <[email protected]>
Signed-off-by: Cho Moon <[email protected]>
Signed-off-by: Cho Moon <[email protected]>
Signed-off-by: Cho Moon <[email protected]>
Signed-off-by: Cho Moon <[email protected]>
Signed-off-by: Cho Moon <[email protected]>
Signed-off-by: Cho Moon <[email protected]>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Cho Moon <[email protected]>
Signed-off-by: Cho Moon <[email protected]>
Signed-off-by: Cho Moon <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
ORFS PR The-OpenROAD-Project/OpenROAD-flow-scripts#3670 goes with this OR PR. |
Signed-off-by: Matt Liberty <[email protected]>
Member
|
I'm reinstating the c++20 changes and will help you get c++20 working for you. |
maliberty
reviewed
Nov 22, 2025
| ,"RSZ::repair_design_buffer_count" : "1206" | ||
| ,"RSZ::max_slew_slack" : "0" | ||
| ,"RSZ::repair_design_buffer_count" : "1326" | ||
| ,"RSZ::max_slew_slack" : "-128.51946394096785" |
Member
There was a problem hiding this comment.
I see various degradations at RSZ that seem to be fixed by DRT. Is that because we are no longer hiding violations that were there before?
Contributor
There was a problem hiding this comment.
Yes, once slew violations are fixed, other timing violations tend to get easier to fix.
maliberty
approved these changes
Nov 22, 2025
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.