-
Notifications
You must be signed in to change notification settings - Fork 2
MS-990 Custom model file support #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
af6b5ce
MS-990 Move reference test embedding to a separate file
luhmirin-s 9b092bc
MS-990 Allow to load model from a provided file instead of generated …
luhmirin-s 3fee0c3
MS-990 Add cleanup for tests
luhmirin-s bd27df7
Increase AVD heap size to load the models for test
luhmirin-s bb543f6
Move custom model reading into a context extention
luhmirin-s File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
src/androidTest/java/com/simprints/simface/CustomModelTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| package com.simprints.simface | ||
|
|
||
| import android.content.Context | ||
| import android.graphics.Bitmap | ||
| import androidx.test.core.app.* | ||
| import com.simprints.simface.core.SimFace | ||
| import com.simprints.simface.core.SimFaceConfig | ||
| import com.simprints.simface.core.Utils | ||
| import kotlinx.coroutines.test.runTest | ||
| import org.junit.After | ||
| import org.junit.Assert.assertArrayEquals | ||
| import org.junit.Before | ||
| import org.junit.Test | ||
|
|
||
| /** | ||
| * This test class makes it trivially easy to run tests with new model files: | ||
| * 1. Add the new model file to the anrdroidTest/res/raw folder | ||
| * 2. Create a new test method | ||
| * 3. Provide the model file name to `openTestModelFile()` | ||
| * 4. Do the testing | ||
| */ | ||
| class CustomModelTest { | ||
| private lateinit var simFace: SimFace | ||
| private lateinit var context: Context | ||
|
|
||
| @Before | ||
| fun setup() { | ||
| context = ApplicationProvider.getApplicationContext() | ||
| simFace = SimFace() | ||
| } | ||
|
|
||
| @After | ||
| fun cleanup() { | ||
| simFace.release() | ||
| } | ||
|
|
||
| @Test | ||
| fun test_processes_face_with_custom_model() = runTest { | ||
| val testModelFile = context.openTestModelFile() | ||
|
|
||
| simFace.initialize( | ||
| SimFaceConfig( | ||
| context, | ||
| customModel = SimFaceConfig.CustomModel( | ||
| file = testModelFile, | ||
| templateVersion = "TEST_1", | ||
| ), | ||
| ), | ||
| ) | ||
| val bitmap: Bitmap = context.loadBitmapFromTestResources("royalty_free_good_face") | ||
| val resultFloat = getFaceEmbeddingFromBitmap(bitmap) | ||
|
|
||
| assertArrayEquals(GOOD_FACE_EMBEDDING, resultFloat, 0.1F) | ||
| } | ||
|
|
||
| private fun getFaceEmbeddingFromBitmap(bitmap: Bitmap): FloatArray = simFace | ||
| .getEmbedding(bitmap) | ||
| .let { Utils.byteArrayToFloatArray(it) } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this, otherwise not really useful to have it as a separate function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty specific for this test class. It was extracted into a function to make the test case easier to read.