MS-990 Custom model file support #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhmirin-s
force-pushed
the
feature/MS-990-custom-model-support
branch
5 times, most recently
from
0c144cc to
649442f
Compare
luhmirin-s
force-pushed
the
feature/MS-990-custom-model-support
branch
from
649442f to
bd27df7
Compare
Thinkorswim
approved these changes
Jun 10, 2025
Collaborator
Thinkorswim
left a comment
Thinkorswim
left a comment
There was a problem hiding this comment.
Looks good to me! Might be useful to separate the files in androidTest into tests and utilities folders to make it a bit cleaner.
| assertArrayEquals(GOOD_FACE_EMBEDDING, resultFloat, 0.1F) | ||
| } | ||
|
|
||
| private fun openTestModelFile(resourceName: String = "edgeface_test"): File { |
Collaborator
There was a problem hiding this comment.
Should we extract this logic into a separate utils file? It seems like it could be reusable across future tests.
Collaborator
Author
There was a problem hiding this comment.
Changed into an extention method of Context and moved to TestContextExt.
| return tempFile | ||
| } | ||
|
|
||
| private fun getFaceEmbeddingFromBitmap(bitmap: Bitmap): FloatArray = simFace |
Collaborator
There was a problem hiding this comment.
Same with this, otherwise not really useful to have it as a separate function.
Collaborator
Author
There was a problem hiding this comment.
This is pretty specific for this test class. It was extracted into a function to make the test case easier to read.
gstrag
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as a spike to see if it is possible, but turned into a pretty nice future-proof solution. Here are the main changes:
Benefits of this change: