Skip to content

Update students.json#158

Open
amdemw206-coder wants to merge 6 commits into
SeattleColleges:mainfrom
amdemw206-coder:add-student-amde-wubshet
Open

Update students.json#158
amdemw206-coder wants to merge 6 commits into
SeattleColleges:mainfrom
amdemw206-coder:add-student-amde-wubshet

Conversation

@amdemw206-coder
Copy link
Copy Markdown

@amdemw206-coder amdemw206-coder commented Mar 3, 2026

Summary & Changes 📃

  • Resolves: Students Page: Add yourself to the Students Page #122

  • Summary:

    • 🔨 What does this issue fix? This Pull Request adds my student profile for the NSC application development website.
    • 👀 What is the expected behavior? To display on the "students" section of the NSC application development website.
    • 🗨️ Any relevant technical details? None.
  • Changes:

    • ✅ Added student profile "Amde Wubshet" to src/students.json

Screenshots / Visual Aids 🔎

📌 Required for: UI changes, layout updates, or bug fixes.

Expand ⬇️ image

How to Test 🧪

  1. Steps to Reproduce:
    • Step 1: After cloning the repository & installing dependencies, run a local development server to view the website in your browser.
    • Step 2: In the src folder, open the students.json file.
    • Step 3: Scroll to the end of the file and input information for student Amde Wubshet.
  2. Expected Behavior: Displays the student information on the site.

Checklist ✅

  • I have tested this PR locally and it works as expected.
  • This PR resolves an issue (Resolves #issue-number).
  • Reviewers, assignees(self), tags, and labels are correctly assigned.
  • Squash commits and enable auto-merge if approved.

Comment thread src/students.json
Copy link
Copy Markdown
Contributor

@sstar691969 sstar691969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

students.json code has no error and bracket was correct and fixed.

Image

@PaulinaS123
Copy link
Copy Markdown
Contributor

Hi, I reviewed the pull request and the failing check is likely caused by an issue in the students.json file format.

The GitHub action “Sync Project Status / sync-status” usually fails when the JSON structure does not exactly match the required format for the project. Please double-check the following:

  1. Make sure all required fields are included (name, program, image, github, linkedin, email, bio).
  2. Verify that commas are placed correctly between fields and that there is no extra comma at the end of the object.
  3. Confirm that all quotation marks and brackets are properly closed.
  4. Check that the image path matches a file that actually exists in the images folder.
  5. Ensure the new student entry follows the same structure as the existing entries in students.json.

After fixing the JSON formatting, commit the changes and push again so the check can rerun.

Once the sync-status check passes, the pull request should be ready to merge.

Copy link
Copy Markdown
Contributor

@josehorta21 josehorta21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the addition of Amde Wubshet's student profile to students.json.
The JSON structure is well-formed (name, photo, role, about, email, github,
linkedin all present and following the surrounding entries' schema), and
the bracket/comma fixes called out by @sstar691969 look clean in the diff.

A few specific observations after going through Files changed:

  1. Placeholder image (anon-profile-image.webp) on line 568. Most
    surrounding entries use personalized photos (e.g., Dmitriy_S_C.webp,
    Copper-Wilson.webp) named after the contributor. Using the anonymous
    placeholder will work technically, but the page renders as a generic
    silhouette rather than a recognizable profile — visible in
    @sstar691969's screenshot where Amde's card shows the default avatar
    while neighboring entries have real photos. Consider uploading a
    personal .webp image (similar naming convention) before merging for
    a more polished directory.

  2. Minor copy edit in the "about" field (line 570). The text reads
    "New to this stuff but i'm excited to learn!" — the lowercase i'm
    should be capitalized (I'm) for consistency with formal site copy.
    Small thing, but worth catching since the page is public-facing.

  3. Auto-merge is enabled with active merge conflicts. This combination
    is a bit risky: the moment the conflict is resolved, auto-merge will
    trigger immediately without a second look. Worth disabling auto-merge
    temporarily while resolving the conflict, then re-enabling it once
    everything is verified, especially since students.json is high-churn
    right now (multiple PRs touching it).

  4. Conflict resolution context. The conflict is in src/students.json,
    which makes sense given that PR #166 and PR #142 are also touching the
    same file. Worth confirming after resolving that all surrounding
    entries from those PRs (or main) are preserved correctly so no other
    contributor's profile gets accidentally dropped.

  5. +1 to @sstar691969's verification. Glad the JSON parses correctly
    and the site renders without errors — that's the most important check
    for this kind of data PR.

Overall the entry itself is solid. Main blockers are the merge conflict
resolution and the auto-merge timing; the photo and copy edit are
optional polish.

@josehorta21
Copy link
Copy Markdown
Contributor

Following up on my review from last week. Checking back on the status:

  1. Merge conflicts still present. The conflict in src/students.json
    hasn't been resolved yet, and auto-merge is still enabled. As noted
    before, this combination is worth being careful with — once the conflict
    resolves, auto-merge will fire immediately. Given that students.json
    keeps accumulating new entries from parallel PRs, the conflict will only
    get harder the longer it sits.

  2. @SUPER444E's "requested changes" is still open. The PR can't merge
    until that review is addressed and re-requested. If the changes have
    already been made in a recent commit, it might just need a ping to
    @SUPER444E to re-review and clear the block.

  3. Suggested next step: resolve the conflict against the latest main
    first (since other student entries have likely landed since this branch
    was created), then ping the reviewers to re-check. Happy to take another
    look once it's rebased and the conflict is cleared.

No new blockers from my side — the entry content itself still looks good.
The hold-up is purely the conflict + pending re-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants