Update students.json#158
Conversation
|
Hi, I reviewed the pull request and the failing check is likely caused by an issue in the students.json file format. The GitHub action “Sync Project Status / sync-status” usually fails when the JSON structure does not exactly match the required format for the project. Please double-check the following:
After fixing the JSON formatting, commit the changes and push again so the check can rerun. Once the sync-status check passes, the pull request should be ready to merge. |
josehorta21
left a comment
There was a problem hiding this comment.
Reviewed the addition of Amde Wubshet's student profile to students.json.
The JSON structure is well-formed (name, photo, role, about, email, github,
linkedin all present and following the surrounding entries' schema), and
the bracket/comma fixes called out by @sstar691969 look clean in the diff.
A few specific observations after going through Files changed:
-
Placeholder image (
anon-profile-image.webp) on line 568. Most
surrounding entries use personalized photos (e.g.,Dmitriy_S_C.webp,
Copper-Wilson.webp) named after the contributor. Using the anonymous
placeholder will work technically, but the page renders as a generic
silhouette rather than a recognizable profile — visible in
@sstar691969's screenshot where Amde's card shows the default avatar
while neighboring entries have real photos. Consider uploading a
personal.webpimage (similar naming convention) before merging for
a more polished directory. -
Minor copy edit in the "about" field (line 570). The text reads
"New to this stuff but i'm excited to learn!" — the lowercasei'm
should be capitalized (I'm) for consistency with formal site copy.
Small thing, but worth catching since the page is public-facing. -
Auto-merge is enabled with active merge conflicts. This combination
is a bit risky: the moment the conflict is resolved, auto-merge will
trigger immediately without a second look. Worth disabling auto-merge
temporarily while resolving the conflict, then re-enabling it once
everything is verified, especially sincestudents.jsonis high-churn
right now (multiple PRs touching it). -
Conflict resolution context. The conflict is in
src/students.json,
which makes sense given that PR #166 and PR #142 are also touching the
same file. Worth confirming after resolving that all surrounding
entries from those PRs (ormain) are preserved correctly so no other
contributor's profile gets accidentally dropped. -
+1 to @sstar691969's verification. Glad the JSON parses correctly
and the site renders without errors — that's the most important check
for this kind of data PR.
Overall the entry itself is solid. Main blockers are the merge conflict
resolution and the auto-merge timing; the photo and copy edit are
optional polish.
|
Following up on my review from last week. Checking back on the status:
No new blockers from my side — the entry content itself still looks good. |

Summary & Changes 📃
Resolves: Students Page: Add yourself to the Students Page #122
Summary:
Changes:
Screenshots / Visual Aids 🔎
📌 Required for: UI changes, layout updates, or bug fixes.
Expand ⬇️
How to Test 🧪
Checklist ✅
Resolves #issue-number).