Skip to content

seattlecolleges.github.io_0_122_Add student name to list of students#142

Open
endlesslupita wants to merge 5 commits into
SeattleColleges:mainfrom
endlesslupita:seattlecolleges.github.io_0_122_Add-student-photo
Open

seattlecolleges.github.io_0_122_Add student name to list of students#142
endlesslupita wants to merge 5 commits into
SeattleColleges:mainfrom
endlesslupita:seattlecolleges.github.io_0_122_Add-student-photo

Conversation

@endlesslupita
Copy link
Copy Markdown

@endlesslupita endlesslupita commented Feb 19, 2026

Summary & Changes 📃

  • Resolves: Students Page: Add yourself to the Students Page #122

  • Summary:

    • 🔨 What does this issue fix? Added name & student info to Students Page
    • 👀 What is the expected behavior? Text should appear formatted like the other students' entries.
  • Changes:

    • ✅ Student data added
image

Photo not uploaded yet.
@bcko bcko marked this pull request as draft February 20, 2026 02:56
@endlesslupita endlesslupita self-assigned this Feb 20, 2026
@endlesslupita endlesslupita marked this pull request as ready for review February 20, 2026 03:35
@endlesslupita endlesslupita removed their assignment Feb 20, 2026
Comment thread src/students.json
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your append did not get put to the end of the list, do you mind following up on this and fix this?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@endlesslupita , can you take a look at this? If you update your PR, make sure to resolve this conversation.

@amdemw206-coder amdemw206-coder self-requested a review March 17, 2026 22:20
@amdemw206-coder
Copy link
Copy Markdown

The format of the .json file looks good. I think you just have to resolve the conflicts in your branch and it should be good.

Copy link
Copy Markdown
Contributor

@bcko bcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve this PR with the condition that you will resolve the PR comment provided by @SUPER444E

@josehorta21 josehorta21 mentioned this pull request May 23, 2026
4 tasks
Copy link
Copy Markdown
Contributor

@josehorta21 josehorta21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the addition of a new student to students.json. The screenshot
in the description shows the entry rendering correctly on localhost, which
is a good sanity check.

A few specific observations after going through Conversation and Files
changed:

  1. Unresolved feedback from @SUPER444E (Mar 7). SUPER444E flagged that
    the new entry didn't get appended to the end of the list, and
    @endlesslupita's commits (Capitalize filename, Add photo and correct filename) addressed naming issues but it isn't clear from the diff
    whether the append-location concern was actually resolved. Worth
    confirming the new entry sits at the bottom of src/students.json in
    the latest state, not somewhere in the middle.

  2. Conversation still open from @bcko (Mar 19). bcko explicitly asked
    @endlesslupita to resolve the SUPER444E conversation thread. Since the
    conversation is still showing as open and there hasn't been activity
    from the author in roughly 3 months, this PR may have stalled. Worth
    either a friendly nudge in the conversation or considering whether the
    PR should be closed and the work picked up in a fresh PR if
    @endlesslupita is no longer active.

  3. Merge conflicts in src/students.json. Same root cause as PRs #158
    and #166 — multiple contributors are appending to the same file in
    parallel. The conflict will need to be resolved against current main
    before this can move forward, and the longer it sits the harder the
    conflict gets as other student entries land.

  4. Resolves #122 overlap. Issue #122 ("Students Page: Add yourself to
    the Students Page") appears to be a shared issue that multiple PRs
    (#158, #166, this one) all reference as "Resolves." Strictly, only one
    PR can close the issue, and the issue itself is more of a recurring
    task than a one-shot. Worth clarifying with a maintainer whether #122
    should be a tracking/umbrella issue rather than something each PR
    closes individually.

  5. Screenshot verification is helpful. The localhost screenshot
    showing Zulbadam Batdelger and Jocelyn Graf rendering correctly is a
    nice touch — that kind of visual confirmation makes review faster,
    especially for first-time contributors. Worth keeping this pattern.

Overall the entry itself looks reasonable, but the PR has been inactive
for ~3 months with unresolved review feedback and merge conflicts. Main
blocker is re-engaging the author (or closing/redirecting the work)
before anything else can move forward.

@josehorta21
Copy link
Copy Markdown
Contributor

Following up on my review from last week. Checking back on the status of
this PR:

  1. Still inactive — no author response. As flagged last week, the
    SUPER444E "requested changes" thread and @bcko's request to resolve it
    remain open, and there's been no activity from @endlesslupita in several
    months. The PR appears to be stalled.

  2. Merge conflicts in src/students.json persist. The conflict still
    needs resolution against current main, and it's only getting harder as
    other student entries land via parallel PRs.

  3. Two failing checks. "Auto-assign PRs to author" and "Sync Project
    Status" are both failing — these are tied to the unresolved conflict and
    pending review state, so they should clear once the underlying issues
    are addressed.

  4. Suggested next step for the team. Since this PR has been open since
    February with no recent author activity, it might be worth a maintainer
    deciding whether to (a) ping @endlesslupita one final time with a
    deadline, or (b) close it and let the work be picked up fresh in a new
    PR. Leaving stalled PRs open with conflicts adds noise to the queue and
    makes it harder to track what's actually in flight.

No new blockers from my side — the original entry content was reasonable,
but the path forward here is really a re-engagement / cleanup decision
rather than a code issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants