-
Notifications
You must be signed in to change notification settings - Fork 0
[Education] Normalize adapter naming metadata #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,30 @@ | ||
| { | ||
| "_comment": "Generated by SecuredMe Education adapter scaffold.", | ||
| "_comment": "Generated by SecuredMe Education adapter scaffold. Name metadata normalized by securedme.education.name-pattern.v1.", | ||
| "schema": "securedme.education.adapter-map.v1", | ||
| "app": { | ||
| "slug": "ffed-qlc", | ||
| "name": "FfeD-QLC", | ||
| "path": "FfeD-QLC-MVP", | ||
| "canonical_domain": "ffed-qlc.securedme.ca", | ||
| "canonical_route": "https://securedme.ca/education/apps/ffed-qlc/", | ||
| "status": "pre-alpha" | ||
| }, | ||
| "naming": { | ||
| "policy": "securedme.education.name-pattern.v1", | ||
| "suite": "SecuredMe Education", | ||
| "canonical_slug": "ffed-qlc", | ||
| "display_name": "FfeD-QLC", | ||
| "repository_name": "FfeD-QLC-MVP", | ||
| "repository_full_name": "SeCuReDmE-main-dev/FfeD-QLC-MVP", | ||
| "adapter_prefix": "securedme-ffed-qlc", | ||
| "codex_adapter": "securedme-ffed-qlc-codex-adapter", | ||
| "antigravity_adapter": "securedme-ffed-qlc-antigravity-adapter", | ||
| "public_route": "https://securedme.ca/education/apps/ffed-qlc/", | ||
| "canonical_domain": "ffed-qlc.securedme.ca", | ||
| "legacy_or_internal_names": [ | ||
| "FfeD-QLC-MVP" | ||
| ] | ||
| }, | ||
|
Comment on lines
+12
to
+27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The newly added
This duplication increases the risk of configuration drift. If the schema allows, consider consolidating these blocks or deprecating the redundant fields in the |
||
| "platform": "codex", | ||
| "adapters": { | ||
| "codex": "securedme-ffed-qlc-codex-adapter", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newly added
namingblock introduces significant redundancy with the existingappblock:canonical_slug(line 15) duplicatesslug(line 5)display_name(line 16) duplicatesname(line 6)repository_name(line 17) duplicatespath(line 7)public_route(line 22) duplicatescanonical_route(line 9)canonical_domain(line 23) duplicatescanonical_domain(line 8)This duplication increases the risk of configuration drift. If the schema allows, consider consolidating these blocks or deprecating the redundant fields in the
appblock to maintain a single source of truth.