Remove deprecated API and integrate minimal launch #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fails on Jazzy because the backport hasn't been released yet, but seems to work otherwise. |
evan-palmer
commented
Jul 24, 2025
| @@ -50,7 +50,8 @@ namespace reach::hardware | |||
| class Alpha5Hardware : public hardware_interface::SystemInterface | |||
| { | |||
| public: | |||
| auto on_init(const hardware_interface::HardwareInfo & info) -> hardware_interface::CallbackReturn override; | |||
| auto on_init(const hardware_interface::HardwareComponentInterfaceParams & info) | |||
There was a problem hiding this comment.
Waiting on the next Jazzy sync before merging this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
This PR removes elements of the ros2_control API that have been deprecated. Additionally, a new launch file was added that does not depend on Gazebo or RViz, allowing minimal installations to still launch the system.
Testing
TBD