Fix env format in Dockerfile #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarburg
changed the title
amarburg
force-pushed
the
233-bug-docker-build-check-complains-about-legacy-env-format
branch
from
fbeda76 to
2edc41e
Compare
evan-palmer
approved these changes
Aug 9, 2024
|
Going to wait for #220 before I merge this one |
|
This should be good to merge once the CI is done |
|
Looks like it needs a rebase first |
…/blue into 233-bug-docker-build-check-complains-about-legacy-env-format
Rebased, waiting for CI ... |
evan-palmer
merged commit 368b25a
into
Robotic-Decision-Making-Lab:main
7 checks passed
|
@mergify backport jazzy iron humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
Co-authored-by: Aaron Marburg <[email protected]> (cherry picked from commit 368b25a)
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
Co-authored-by: Aaron Marburg <[email protected]> (cherry picked from commit 368b25a)
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
Co-authored-by: Aaron Marburg <[email protected]> (cherry picked from commit 368b25a)
evan-palmer
pushed a commit
that referenced
this pull request
Aug 19, 2024
Co-authored-by: Aaron Marburg <[email protected]> (cherry picked from commit 368b25a) Co-authored-by: Aaron Marburg <[email protected]>
evan-palmer
pushed a commit
that referenced
this pull request
Aug 19, 2024
Co-authored-by: Aaron Marburg <[email protected]> (cherry picked from commit 368b25a) Co-authored-by: Aaron Marburg <[email protected]>
evan-palmer
pushed a commit
that referenced
this pull request
Aug 19, 2024
Co-authored-by: Aaron Marburg <[email protected]> (cherry picked from commit 368b25a) Co-authored-by: Aaron Marburg <[email protected]>
amarburg
deleted the
233-bug-docker-build-check-complains-about-legacy-env-format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Fixes three ENVs into the preferred "key=value" format.
Associated Issues
docker build --checkcomplains about legacy ENV format #233Testing
docker build --check .produces: