-
Notifications
You must be signed in to change notification settings - Fork 13
[FEATURE]: Add 6328 single-tag pose estimation #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vncero
wants to merge
8
commits into
RoboLancers:main
Choose a base branch
from
vncero:vision
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
dcf22ca
feat(6328 single tag estimation): add support for single tag estimate…
vncero f0cc7ac
fix(6328 single tag estimation): resolve build errors (which were not…
vncero 93f089a
feat(6328 single tag estimation): address review comments
vncero 7b199b1
feat(ambiguity): added admbiguity to std dev calc
AT727 8a423c0
fix(vision): address review comment with logic to use reef pose estim…
vncero 5488c5b
fix(merge): Merge branch 'vision' of https://github.com/Vncero/321-Re…
vncero 46b6780
fix(merge): Merge branch 'main' of https://github.com/RoboLancers/321…
vncero 1bb15df
fix(spotless): ran spotless
vncero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
src/main/java/frc/robot/subsystems/vision/EstimateType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| /* (C) Robolancers 2025 */ | ||
| package frc.robot.subsystems.vision; | ||
|
|
||
| import edu.wpi.first.epilogue.Logged; | ||
|
|
||
| @Logged | ||
| public enum EstimateType { | ||
| SINGLE_TAG, | ||
| MULTI_TAG | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any way to return both? Right now, if we don't see 2+ tags in auto, our main pose estimate won't update its angle, which means our angles would be a bit wrong, resulting in big errors for the single tag estimate. Adding multitag to the main pose estimate no matter what, with ambiguity filters, might resolve that.
tldr: add multitag estimate to main pose estimate always, but not single tag; add single tag or multitag estimate to reef pose estimate?
better yet: for alignment, add a method to see if we see a specific reef tag with our reef cameras. If we do see it, we use the reef pose estimate; otherwise, we use the main pose estimate until we do see it. This helps eliminate any blind spots through the use of a third non-reef camera for the main pose estimate.
I'm just guessing here, idk if it'll work. We might benefit hugely from a meeting with 6328 with our vision routine.