-
Notifications
You must be signed in to change notification settings - Fork 13
[FEATURE]: Add 6328 single-tag pose estimation #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…s when close to reef, add EstimateType field to VisionEstimate for logging which type of estimate was produced
BananasAmIRite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see changes
|
Also, add the vision logging changes here too. |
… caught due to lack of tooling, githooks do not work)
|
Will add logging changes in another PR due to concerns with slowing down this relatively high priority feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look @ comments
also are you sure you don't wanna meet w/ 6328?
| }) | ||
| .orElse(null); | ||
|
|
||
| return switch (latestResult.targets.size()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any way to return both? Right now, if we don't see 2+ tags in auto, our main pose estimate won't update its angle, which means our angles would be a bit wrong, resulting in big errors for the single tag estimate. Adding multitag to the main pose estimate no matter what, with ambiguity filters, might resolve that.
tldr: add multitag estimate to main pose estimate always, but not single tag; add single tag or multitag estimate to reef pose estimate?
better yet: for alignment, add a method to see if we see a specific reef tag with our reef cameras. If we do see it, we use the reef pose estimate; otherwise, we use the main pose estimate until we do see it. This helps eliminate any blind spots through the use of a third non-reef camera for the main pose estimate.
I'm just guessing here, idk if it'll work. We might benefit hugely from a meeting with 6328 with our vision routine.
Raptura
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all looks good outside of what jason already requested of you
|
New vision pipeline:
|
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Adds support for single tag estimates when close to reef via PhotonVision's
PoseStrategy.PNP_DISTANCE_TRIG_SOLVE. Note that eachCamerainstance internally switches between single- and multi-tag estimation depending on how many tags are seen, which propagates upward intoVisionand thus theSwerveDrive's pose estimator. Further adds an EstimateType field to VisionEstimate for logging which type of estimate was produced (full logging for vision beyond PhotonVision's existing logging will be written soon).Type of change
Please delete options that are not relevant.
Checklist: