-
Notifications
You must be signed in to change notification settings - Fork 1
Branch with a slash #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pkaminski
wants to merge
9
commits into
master
Choose a base branch
from
pkaminski/ts-file
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
67f6b83
Create fresh.ts
pkaminski bff0156
Update fresh.ts
pkaminski 3812788
Commit A
pkaminski 03837bd
Commit B
pkaminski 607db55
Update fresh.ts
pkaminski 0f54866
Update fresh.ts
pkaminski b8fd661
Update fresh.ts
pkaminski d61036d
Update fresh.ts
pkaminski-test 98b5c31
Change return value of bar getter from 'baz' to 'bazzz'
pkaminski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // A fresh file with something inside it | ||
|
|
||
| export class Foo { | ||
| get bar() { | ||
| return 'bazzz'; | ||
| } | ||
| } | ||
|
|
||
| // Commit A | ||
|
|
||
| // Commit B | ||
pkaminski marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // Commit C3 | ||
|
|
||
| // Edit by reviewer | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another new unresolved comment.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reply to unresolved comment. Then edited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reply posted in bigger review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up comment.