Skip to content

Branch with a slash#20

Open
pkaminski wants to merge 9 commits intomasterfrom
pkaminski/ts-file
Open

Branch with a slash#20
pkaminski wants to merge 9 commits intomasterfrom
pkaminski/ts-file

Conversation

@pkaminski
Copy link
Copy Markdown
Member

@pkaminski pkaminski commented Sep 18, 2025

This change is Reviewable

@pkaminski-test
Copy link
Copy Markdown

ohi

Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publish this on push

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@pkaminski-test
Copy link
Copy Markdown

Ad-hoc comment

@pkaminski
Copy link
Copy Markdown
Member Author

Ad-hoc comment from author

Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


a discussion (no related file):
Your turn

Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkaminski-test reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @pkaminski)

@pkaminski
Copy link
Copy Markdown
Member Author

A between-commits comment on GitHub.

@pkaminski pkaminski requested review from pkaminski-test and removed request for pkaminski-test October 14, 2025 21:28
Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkaminski reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pkaminski-test)


a discussion (no related file):

Previously, pkaminski-test wrote…

Your turn

Done.

Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkaminski dismissed @pkaminski-test from a discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pkaminski-test)

}
}

// Commit A
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another new unresolved comment.

Copy link
Copy Markdown
Member Author

@pkaminski pkaminski Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reply to unresolved comment. Then edited.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reply posted in bigger review.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up comment.

}
}

// Commit A
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reply posted in bigger review.

@pkaminski
Copy link
Copy Markdown
Member Author

Issue comment.

@pkaminski
Copy link
Copy Markdown
Member Author

Another issue comment.

@pkaminski
Copy link
Copy Markdown
Member Author

Once more, with feeling.

Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foo

Copy link
Copy Markdown

@pkaminski-test pkaminski-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bar

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 18 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

2

2

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 21 at r4:
3

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 21 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

3

3

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 18 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

2

2

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 18 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

2

2

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 18 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

2

2

@pkaminski
Copy link
Copy Markdown
Member Author

asdf

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @pkaminski-test)


-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

asdf

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

asdf

1

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @pkaminski-test)


-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 18 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

2

2

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @pkaminski-test)


-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rwer

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @pkaminski-test)

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

Copy link
Copy Markdown
Member Author

@pkaminski pkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3r

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @pkaminski-test)

@pkaminski
Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski
Copy link
Copy Markdown
Member Author

foo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants