Skip to content

fix: provide a specific error message when recording permission is denied #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joanise wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: provide a specific error message when recording permission is denied #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/studio-web/src/app/upload/upload.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,15 @@ Please check it to make sure all words are spelled out completely, e.g. write "4
await this.microphoneService.startRecording();
this.recording = true;
} catch (err: any) {
this.toastr.error(err.toString(), $localize`Could not start recording!`);
let message;
if (err.name === "NotAllowedError") {
message = $localize`Microphone access was denied. Please grant microphone access to use this feature.`;
} else {
message = err.toString();
}
this.toastr.error(message, $localize`Could not start recording!`, {
timeOut: 15000,
});
} finally {
this.starting_to_record = false;
}
Expand Down
1 change: 1 addition & 0 deletions packages/studio-web/src/i18n/messages.es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@
"1549389605329660619": "Esto es realmente difícil. Lo intentaremos una última vez, pero puede llevar mucho tiempo y producir malos resultados. Asegúrese de que su texto coincida con su audio y que haya el menor ruido de fondo posible.",
"6071928720301938306": "El procesamiento del audio falló.",
"3763839702998678686": "No hay audio para descargar.",
"3513286828638574591": "Permiso de micrófono denegado. Por favor, concede acceso al micrófono para grabar.",
"4183225119057268962": "¡No se pudo empezar la grabación!",
"2596823344081631983": "El audio se grabó con éxito. Por favor escuche su grabación para asegurarse de que está correcta y si lo está, guárdela para reusarla luego.",
"1317075918959775059": "¡Hurra!",
Expand Down
1 change: 1 addition & 0 deletions packages/studio-web/src/i18n/messages.fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@
"1549389605329660619": "C'est vraiment difficile. Nous allons essayer une dernière fois, mais ça peut être long et donner de mauvais résultats. Veuillez vous assurer que votre texte correspond à votre audio et qu'il y a le moins de bruit de fond possible.",
"6071928720301938306": "Échec de traitement de l'audio.",
"3763839702998678686": "Pas d'audio à télécharger.",
"3513286828638574591": "Autorisation du micro refusée. Prière d'accorder l'accès au micro pour pouvoir enregistrer.",
"4183225119057268962": "Impossible de démarrer l'enregistrement!",
"2596823344081631983": "Audio enregistré avec succès. Prière d'écouter votre enregistrement pour le valider et de le sauvegarder s'il est bon.",
"1317075918959775059": "Bravo!",
Expand Down
1 change: 1 addition & 0 deletions packages/studio-web/src/i18n/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@
"1549389605329660619": "This is really difficult. We'll try one last time, but it might take a long time and produce poor results. Please make sure your text matches your audio and that there is as little background noise as possible.",
"6071928720301938306": "Audio processing failed.",
"3763839702998678686": "No audio to download.",
"3513286828638574591": "Microphone access was denied. Please grant microphone access to use this feature.",
"4183225119057268962": "Could not start recording!",
"2596823344081631983": "Audio was successfully recorded. Please listen to your recording to make sure it's OK, and save it for reuse if so.",
"1317075918959775059": "Yay!",
Expand Down
Loading