fix: provide a specific error message when recording permission is denied#548
Open
fix: provide a specific error message when recording permission is denied#548
Conversation
|
Review changes with Changed Files
|
Contributor
|
joanise
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
This is work I did a long time ago, but I forgot to PR it...
If microphone permission is denied, this PR shows:
Before this PR:
Fixes?
Fixes #149
Well, really, it finishes fixing that issue by adding a friendlier user message when microphone permission is denied; the other half of the issue was done in #154, and all this is work that builds on top of #127.
How to test?
Open the PR preview and the prod version in an incognito window, and refuse microphone access when prompted.
Confidence?
high
Version change?
no