btcli v11 UX, wallet compat, and alpha-fee runtime fixes (combines #3046–#3051) - #3052
btcli v11 UX, wallet compat, and alpha-fee runtime fixes (combines #3046–#3051)#3052unarbos wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE MEDIUM scrutiny: account is ~5 months old and commit author differs from PR author, offset by repository write permission and extensive substantive merged history; no Gittensor association found. Branch: feat/btcli-combined → fix/testnet-grandpa-finality-sdk-pin. Static analysis found no malicious behavior or security vulnerability in the runtime nonce relaxation, keyfile compatibility changes, multisig intent wrapping, secret-handling paths, or regenerated dependency lockfile. No AI-review trust-boundary files are modified. FindingsNo findings. ConclusionNo security-blocking issues were found in the current diff. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor association UNKNOWN; established high-volume contributor with repository write access. The implementation matches the substantive PR description. The latest multisig adapter preserves the underlying intent’s spend, subnet, policy, and mandatory MEV-shielding semantics, with focused regression tests. The runtime nonce change remains narrowly scoped and correctly accounts for its additional storage read. The overlapping PRs concern unrelated behavior despite sharing release/runtime files. No auto-fixes were needed, and no runtime checks were rerun because static review found no issue requiring confirmation. FindingsNo findings. ConclusionReady to merge: no substantive correctness, domain-rule, testing, or description issues were found. |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: VULNERABLE |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
eco-tests changed — indexer review requiredThis PR modifies files under Changed files
|
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Combine the btcli UX, multisig, dry-run, secret-handling, name-resolution, SDK compatibility, and alpha-fee runtime updates into a single signed change.
1379b3f to
c1b8d0b
Compare
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
3 participants
Summary
Combines the six open btcli PRs plus two new fixes into one branch off
main. Supersedes #3046, #3047, #3048, #3049, #3050, #3051.From the six PRs
-w <multisig>works for submissions and reads (wallet balance,overview,stake list), plus wallet regeneration from 64-byte private keys.allamounts, hotkey picker, paste-any-ss58 targets,stake burn; also includes the v9-migration fixes from Discord feedback (--no-promptalias,unstake-allhint, legacy-config warning, UIDs inwallet overview).--dry-run --jsoncarriesspend_tao,spend_unbounded,args, and the replay command for agent pre-approval.wallet decrypt --copy, no-echo prompt fallbacks.--call/--argsJSON with did-you-mean errors replacing "Base 58 requirement is violated".New in this PR
CheckNoncerejected fee-paying extrinsics from coldkeys holding only transferred alpha (zero providers/sufficients, no free TAO) before the alpha fee fallback could run. Reference-less signers with alpha stake now pass; extension weight accounts for the extraStakingHotkeysread. Addsruntime/tests/alpha_only_coldkey_fees.rsreproducing the reportedstake removefailure.Keypairretains its mnemonic/seed sosecretPhrase/secretSeedare written again (strict legacy parsers such as Apex's subnet tooling require them). The reader now accepts stringcryptoType, self-heals wrong/missingcryptoTypevia the stored ss58 address, parses pre-JSON raw seeds/mnemonics, and gives an actionable error for polkadot.js / mobile-app exports.Merge notes
cli/commands/wallet.py: feat(cli): treat saved multisig names as -w wallets #3046's--private-keyregen options vs feat(cli): keep key material out of shell history, ps output, and scrollback #3049'swarn_argv_secrets— resolved to warn on--private-keytoo.ruff formatdrift from the merges fixed in a follow-up style commit.Test plan
cargo test -p bittensor-core --lib— 63 passedcargo test -p node-subtensor-runtime --test alpha_only_coldkey_feesand--lib check_nonce— passedpytest sdk/python/tests/unit— 1069 passed, 1 skippedruff check+ruff format --checkcleanMade with Cursor
Release
bittensor11.0.2.dev0 → 11.1.0.dev0 (11.0.2 already on PyPI; releases as 11.1.0)bittensor-core0.1.2 → 0.1.3 (core keyfile changes; SDK floor bumped to match)spec_version443 → 444 (CheckNonce fix is a runtime behavior change; the train ships on spec bumps)uv.lockregenerated with CI's pinned uv 0.11.28 (one-time upload-time metadata churn)