fix(cli): harden key import and prompt policies - #3054
Conversation
Restore raw 64-byte private keys without truncation, share one address-resolution path for flags and nested calls, and move intent-specific prompt behavior behind a declarative policy. Add regression coverage and apply pending Rust formatting.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE HIGH scrutiny: the account is 34 days old with zero public repos, but has repository admin permission, substantial merged history, no author/committer mismatch, and no identified Gittensor association; fix/btcli-combined-audit -> feat/btcli-combined. Static review found the key-import change preserves full 64-byte sr25519 private keys, while the account-resolution and prompt-policy changes remain confined to CLI behavior. No runtime, dependency, CI, or AI-review trust-boundary changes are present. FindingsNo findings. ConclusionNo malicious behavior or security vulnerability was found in the PR delta. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor association: UNKNOWN; established repository admin with substantial recent contributions. Overlap is with the parent integration PR #3052 and incidental formatting elsewhere, not competing work. The key restoration fix preserves full 64-byte sr25519 private keys, account-name resolution is consistently centralized, and the prompt-policy refactor retains the existing behavior with focused regression coverage. This targets a feature integration branch, so no runtime spec-version bump is required. FindingsNo findings. ConclusionThe implementation matches the substantive PR description and introduces no blocking correctness, testing, or maintainability issues. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Summary
Verification
cargo fmt --all -- --checkcargo test -p bittensor-core keyfiles --lib(17 passed)cargo clippy -p bittensor-core --all-targets -- -D warningsruff check sdk/python/bittensor sdk/python/tests/unitruff format --check sdk/python/bittensor sdk/python/tests/unitpytest -q tests/unit(1079 passed, 1 skipped)