Skip to content

fix(cli): harden key import and prompt policies - #3054

Merged
UnArbosFive merged 1 commit into
feat/btcli-combinedfrom
fix/btcli-combined-audit
Aug 5, 2026
Merged

fix(cli): harden key import and prompt policies#3054
UnArbosFive merged 1 commit into
feat/btcli-combinedfrom
fix/btcli-combined-audit

Conversation

@UnArbosFive

Copy link
Copy Markdown
Contributor

Summary

  • restore raw 64-byte sr25519 private keys without truncating them into unrelated seeds
  • route flag and nested-call account names through one canonical resolver, including saved multisigs
  • stop inferring arbitrary string lists as account lists
  • move intent-specific picker and balance prompts into a declarative policy registry
  • apply the Rust formatting currently blocking the target branch

Verification

  • cargo fmt --all -- --check
  • cargo test -p bittensor-core keyfiles --lib (17 passed)
  • cargo clippy -p bittensor-core --all-targets -- -D warnings
  • ruff check sdk/python/bittensor sdk/python/tests/unit
  • ruff format --check sdk/python/bittensor sdk/python/tests/unit
  • pytest -q tests/unit (1079 passed, 1 skipped)

Restore raw 64-byte private keys without truncation, share one address-resolution path for flags and nested calls, and move intent-specific prompt behavior behind a declarative policy. Add regression coverage and apply pending Rust formatting.
@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
subtensor Ready Ready Preview Aug 5, 2026 11:25pm

Request Review

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

HIGH scrutiny: the account is 34 days old with zero public repos, but has repository admin permission, substantial merged history, no author/committer mismatch, and no identified Gittensor association; fix/btcli-combined-audit -> feat/btcli-combined.

Static review found the key-import change preserves full 64-byte sr25519 private keys, while the account-resolution and prompt-policy changes remain confined to CLI behavior. No runtime, dependency, CI, or AI-review trust-boundary changes are present.

Findings

No findings.

Conclusion

No malicious behavior or security vulnerability was found in the PR delta.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor association: UNKNOWN; established repository admin with substantial recent contributions. Overlap is with the parent integration PR #3052 and incidental formatting elsewhere, not competing work.

The key restoration fix preserves full 64-byte sr25519 private keys, account-name resolution is consistently centralized, and the prompt-policy refactor retains the existing behavior with focused regression coverage. This targets a feature integration branch, so no runtime spec-version bump is required.

Findings

No findings.

Conclusion

The implementation matches the substantive PR description and introduces no blocking correctness, testing, or maintainability issues.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@UnArbosFive
UnArbosFive merged commit fb7bb82 into feat/btcli-combined Aug 5, 2026
49 checks passed
@UnArbosFive
UnArbosFive deleted the fix/btcli-combined-audit branch August 5, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant