dist/tools: add static check for missing board doc.md files#22240
Merged
crasbe merged 2 commits intoRIOT-OS:masterfrom May 6, 2026
Merged
dist/tools: add static check for missing board doc.md files#22240crasbe merged 2 commits intoRIOT-OS:masterfrom
crasbe merged 2 commits intoRIOT-OS:masterfrom
Conversation
Author
|
OK, thanks for the review! |
Contributor
|
Perhaps you can use the opportunity to also change the wording in our guides about Porting Boards: https://doc.riot-os.org/advanced_tutorials/porting_boards/#docmd (in Something like this: diff --git a/doc/guides/advanced_tutorials/porting_boards.mdx b/doc/guides/advanced_tutorials/porting_boards.mdx
index 1d0ab59fc4..c4b8f121ec 100644
--- a/doc/guides/advanced_tutorials/porting_boards.mdx
+++ b/doc/guides/advanced_tutorials/porting_boards.mdx
@@ -197,9 +197,12 @@ PROGRAMMER ?= openocd
### doc.md
-Although not explicitly needed, if upstreamed and as a general good
-practice, this file holds all `BOARD` documentation. This can include
+This file holds all `BOARD` documentation and is a necessary prerequisite
+for every new board that is ported. This file can (and should) include
datasheet reference, documentation on how to flash, etc.
+Proper documentation about your board makes it easier for others to use it
+to the full capacity. Remember to also mention any features that are not
+supported yet!
The documentation must be under the proper doxygen group, you can compile the
documentation by calling `make doc` and then open the generated html file on |
2cd677c to
2cb0a95
Compare
maribu
reviewed
May 5, 2026
crasbe
approved these changes
May 6, 2026
Contributor
crasbe
left a comment
There was a problem hiding this comment.
Looks good. You don't have to necessarily re-request a review, I get e-mail notifications about any changes and any conversation in this PR anyways.
You can squash the three commits regarding the new static test and leave two commits overall: one for the new static test and one for the guides change.
Co-authored-by: crasbe <crasbe@gmail.com> Co-authored-by: Marian Buschsieweke <maribu@users.noreply.github.com>
e84f6f7 to
76e9269
Compare
Contributor
|
Thank you for providing the test and congratulations to your first RIOT contribution 🥳 |
Author
|
Thank you too (and maribu) for the feedback and suggestions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds a static test (.sh script) that checks whether every ported board has a mandatory doc.md file.
The "common" directory is skipped as it's not a standalone ported board.
Testing procedure
./dist/tools/board_doc_check/check.sh
or make static-test
If all boards contain the required doc.md file, the test passes silently. Otherwise, it fails and reports the directories where the required file is missing.
Issues/PRs references
Closes #22224. See also #22221.
Depends on #22221.
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: