.github/workflows: reduce check-labels triggering

[crasbe]

Contribution description

Currently the check-labels test creates a lot of noise as it is triggered with every push when a label is present that prevents the test from succeeding.

This can be annoying for core development, when the needs >1 ACK label is present.

The proposed change removes the synchronize trigger. This might lead to side effects where the check-labels test is not executed and therefore prevents a merge, that's why I added auto-merge-enabled as a trigger. That might affect @maribu who likes to enable Auto Merge when opening a PR :D

Perhaps one of you has a better idea of what to use additionally? https://docs.github.com/de/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request_target

enqueued won't help because it can't be queued without the check.

Testing procedure

I'll play around with it in this PR.
Trust me, bro.

Issues/PRs references

Fixes #21099.

Declaration of AI-Tools / LLMs usage:

AI-Tools / LLMs that were used are:

• none

[crasbe]

Okay, this can't be tested in RIOT-OS/RIOT, because the test run from on the master version for safety reasons (it uses pull_request_target).

Therefore I tested it in my local fork crasbe#1 and it works as expected.

You can see that the label test was not run after adding the last commit:

It was run when removing the label:

[riot-ci]

Murdock results

✔️ PASSED

f5e327d dist/tools: add GitHub workflows to can_fast_ci_run

Success	Failures	Total	Runtime
1	0	1	01m:41s

Artifacts

• Documentation preview

[maribu]

Could you try sneaking in this change:

diff --git a/dist/tools/ci/can_fast_ci_run.py b/dist/tools/ci/can_fast_ci_run.py
index 8880314ef8..9f319c50b6 100755
--- a/dist/tools/ci/can_fast_ci_run.py
+++ b/dist/tools/ci/can_fast_ci_run.py
@@ -22,7 +22,7 @@ OTHER_CLASSIFIERS = [
     [re.compile(r"^(drivers\/include\/.*|sys\/include\/.*)$"), "public-headers"],
     [re.compile(r"^(Kconfig|kconfigs\/.*|pkg\/Kconfig|sys\/Kconfig|drivers\/Kconfig)$"), "kconfig"],
     [re.compile(r"^(.*\.cff|doc\/.*|.*\.md|.*\.txt)$"), "doc"],
-    [re.compile(r"^(CODEOWNERS|\.mailmap|\.gitignore|\.github|\.gitattributes)$"), "git"],
+    [re.compile(r"^(CODEOWNERS|\.mailmap|\.gitignore|\.github.*|\.gitattributes)$"), "git"],
     [re.compile(r"^(\.murdock|dist\/ls\/.*|\.drone.yml)$"), "ci-murdock"],
     [re.compile(r"^(\.bandit|\.drone.yml)$"), "ci-other"],
     [re.compile(r"^(dist\/.*|Vagrantfile|\.clang-format|\.clang-tidy)$"), "tools"],

That way it would directly test if the fixed regex would no match .github/workflows.

[maribu]

Or maybe even

diff --git a/dist/tools/ci/can_fast_ci_run.py b/dist/tools/ci/can_fast_ci_run.py
index 8880314ef8..77d66754e3 100755
--- a/dist/tools/ci/can_fast_ci_run.py
+++ b/dist/tools/ci/can_fast_ci_run.py
@@ -22,7 +22,8 @@ OTHER_CLASSIFIERS = [
     [re.compile(r"^(drivers\/include\/.*|sys\/include\/.*)$"), "public-headers"],
     [re.compile(r"^(Kconfig|kconfigs\/.*|pkg\/Kconfig|sys\/Kconfig|drivers\/Kconfig)$"), "kconfig"],
     [re.compile(r"^(.*\.cff|doc\/.*|.*\.md|.*\.txt)$"), "doc"],
-    [re.compile(r"^(CODEOWNERS|\.mailmap|\.gitignore|\.github|\.gitattributes)$"), "git"],
+    [re.compile(r"^(CODEOWNERS|\.mailmap|\.gitignore|\.gitattributes)$"), "git"],
+    [re.compile(r"^\.github/.*$"), "github"],
     [re.compile(r"^(\.murdock|dist\/ls\/.*|\.drone.yml)$"), "ci-murdock"],
     [re.compile(r"^(\.bandit|\.drone.yml)$"), "ci-other"],
     [re.compile(r"^(dist\/.*|Vagrantfile|\.clang-format|\.clang-tidy)$"), "tools"],

?

[maribu]

Locally it does work:

master:

./dist/tools/ci/can_fast_ci_run.py --debug --explain
Couldn't classify changes: File ".github/workflows/check-labels.yml" doesn't match any known category

with above diff:

./dist/tools/ci/can_fast_ci_run.py --debug --explain
Other
=====

github
------

- .github/workflows/check-labels.yml

[crasbe]

Yes, seems to work as intended 👍

[crasbe]

Thanks and thanks for the quick fix too! :)

[crasbe]

Just tested this with #22240 and hitting auto merge indeed does trigger the check-labels workflow and enables the merge process. It works as expected :)

[kfessel]

many Thanks