support HTML5 form attribute
#267
Conversation
By searching for input elements also outside the form tag itself, which belong to this form according to their `form` attribute. closes Pylons#8
JohaJung
force-pushed
the
html5_form_attr
branch
from
44a1bac to
625bca4
Compare
|
This will require some more tests. Also you're not keeping field orders. You're just adding html5 fields at the end. I'm not sure it's a very usefull feature but since it exists it should always works. |
|
I changed the logic to preserve field order. Also I wrote a basic test ensuring that inputs are found and kept in correct order. What else are properties you'd like to have tested? |
|
@gawel Any chance to get an update on this? Your previous code-related comments seem to have been applied. While I also agree with you that in most cases it is preferable to structure ones html such that the form attribute is not necessary, this is not always possible. We would also like to have this feature available for our codebase :) |
webtest/forms.py
Outdated
| tags = ('input', 'select', 'textarea', 'button') | ||
| for pos, node in enumerate(self.html.find_all(tags)): | ||
| inner_elts = self.html.find_all(tags) | ||
| if self.response: |
There was a problem hiding this comment.
I don't understand why you need this. Is there any case where response is None ? Is it just for testing ?
There was a problem hiding this comment.
I am not deep enough into it to confirm response could be none in real applications, but in this repo there is TestFormLint::test_form_lint which initializes a Form with response None (and this test errored on my first attempt without this catch). So I guess it's just for testing.
There was a problem hiding this comment.
If it's the only test, can you try to use webtest.TestResponse('<body></body>') instead of None ? Not sure it'll work but it will be cool to avoid this if
There was a problem hiding this comment.
This exact proposal did not work, but embedding the form html that is being linted in a <body>-Tag worked.
(Taking only the form html without surrounding body did work, too. But I considered this one line more worth having actual valid HTML in the response)
Thanks for commenting and helping out!
I just added a comment but yes, seems fair enough |
make the response more likely to be a real-world response
This basically implements what was proposed by @IwanVosloo in #8. Find inputs outside the form tag itself by searching for input elements in the whole response HTML to their
formattribute.closes #8
This is my first PR in this repository, so if there are any style/workflow guidelines I did not recognize or misunderstood, please let me know and I'll try to improve :)