bugfix: form input discovery #270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BeatifulSoup considers inputs as equal if they have the same HTML representation. This broke checks like
tag in list_of_tags
in an unexpected way.In cases like
webtest v3.0.5 consideres the outer
bar
input belonging toouter_inputs_form
.I'm sorry that I overlooked that in #267 .
Now, I added a test which reveals this bug, and fixed the input field discovery (which I adjusted in #267 and thereby introduced that bug).
@gawel not sure how severe that bug is, but it has the potential to break stuff if webtest is used on pages with multiple forms on one page.