Options Menu additions/fixes

[forkymcforkface]

Description

This PR adds the ability to change in the UI:
Hide Rom file extensions
Hide ROM Tags
Hides Dir '/' (no setting for it)!
Hide all saves folders

Moved:
Load progress bar to UI option

Motivation and Context

Cleans up the UI for those that don't need all information

How Has This Been Tested?

Tests were run on SC64 on Original N64. small change was made to load_rom.c to catch a crash.

Types of changes

• Improvement (non-breaking change that adds a new feature)
• Bug fix (fixes an issue)
• Breaking change (breaking change)
• Documentation Improvement
• Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

You agree with the license terms and that other license types may be granted with permission of the original N64FlashcartMenu project license holders.

Signed-off-by: [email protected]

Summary by CodeRabbit

• New Features

  • Added settings to hide file extensions, ROM tags, and the saves folder in the file browser.
  • New options are available in the settings menu to toggle these visibility preferences.
  • The file browser and settings editor interfaces reflect these new customization options for improved user control.

• Style

  • Improved formatting and clarity in the settings editor display text.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Three new boolean settings—hide_extension, hide_rom_tags, and hide_saves_folder—were added to the settings structure and integrated throughout the menu system. These settings are loaded, saved, and exposed via the settings editor UI, affecting how files and folders are displayed in the browser, including logic to optionally hide file extensions, ROM tags, and the saves folder.

Changes

File(s)	Change Summary
src/menu/settings.c, src/menu/settings.h	Added three boolean fields (hide_extension, hide_rom_tags, hide_saves_folder) to the settings structure; updated logic to load and save these fields from/to the configuration file.
src/menu/views/browser.c	Added helper functions to strip file extensions and ROM tags; updated directory and file rendering logic to hide extensions, ROM tags, and the saves folder based on settings.
src/menu/views/settings_editor.c	Integrated new settings into the settings editor UI, including setter functions, context menus, and display text; updated logic to handle and reflect the new settings.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SettingsEditor
    participant Settings
    participant Browser

    User->>SettingsEditor: Opens settings menu
    SettingsEditor->>Settings: Loads current settings
    User->>SettingsEditor: Changes hide_extension/hide_rom_tags/hide_saves_folder
    SettingsEditor->>Settings: Updates and saves new setting
    SettingsEditor->>Browser: Triggers browser reload (if needed)
    Browser->>Settings: Reads updated settings
    Browser->>Browser: Applies hiding logic when displaying files/folders

Loading

Suggested labels

enhancement

Poem

Three new toggles, hop and hide,
Extensions gone, let tags subside.
The "saves" folder, now out of sight,
Browsing menus feels just right!
With every tweak, the view refines—
A rabbit’s joy in tidy lines.
🐇✨

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[networkfusion]

Given there is no real convention for ROM Tags, I am not sure if it is a great idea (given your current implementation), so would require extensive testing. Fully support the "hide save folders" and "hide ROM extensions" though.

[networkfusion]

#203 #235

[forkymcforkface]

Given there is no real convention for ROM Tags, I am not sure if it is a great idea (given your current implementation), so would require extensive testing. Fully support the "hide save folders" and "hide ROM extensions" though.

I was looking at the code and it can be refactored into file_list.c which will be much cleaner if you are ok with reviewing those chsnges.

I implemented this code because Hiding ROM tags is a part of many emulation front end scrapers and metadata editors.

EmulationStation
RetroPie
Batocera
LaunchBox / BigBox
Pegasus
RGB-Pi UI

[networkfusion]

In the latest develop commits, I have wrapped the autoload functionality in ifdef flags, so you can keep the progress bar changes, but keep them in the ifdef's...

[forkymcforkface]

hmm moving it back into ifdef broke it. Im just going to remove it. No time to develop this further.

[networkfusion]

hmm moving it back into ifdef broke it. Im just going to remove it. No time to develop this further.

Only this bit:

[forkymcforkface]

ok, nvm figured it out.

[forkymcforkface]

Thank you @networkfusion for the review. I do not have a dev background so I kinda flail at this stuff.