Skip to content

Conversation

@networkfusion
Copy link
Collaborator

@networkfusion networkfusion commented Dec 30, 2024

Description

This is a template to show others how a new emulator could be added to the menu source code. In this PR we attempt to:
Adds base support for a Sinclair ZX Spectrum emulator (since one is contained within Goldeneye).

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that adds a new feature)
  • Bug fix (fixes an issue)
  • Breaking change (breaking change)
  • Documentation Improvement
  • Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>

Adds ROM extension support, but until someone creates a specific emulator, just uses a generic filename.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 30, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@networkfusion networkfusion changed the title Add support for zx-spectrum Add support for ZX Spectrum emulator Dec 30, 2024
@networkfusion networkfusion changed the title Add support for ZX Spectrum emulator [Template] Add support for ZX Spectrum emulator Dec 30, 2024
@networkfusion networkfusion force-pushed the develop branch 2 times, most recently from 5149c5e to 696af27 Compare January 4, 2025 23:37
@networkfusion networkfusion force-pushed the develop branch 2 times, most recently from 9cf3c1f to 9b69b84 Compare March 8, 2025 01:19
@networkfusion networkfusion force-pushed the develop branch 6 times, most recently from 3302dc6 to 7b68b2f Compare July 7, 2025 20:01
@networkfusion networkfusion force-pushed the develop branch 13 times, most recently from 2fd7dd7 to bfb4e22 Compare October 7, 2025 21:42
@networkfusion networkfusion force-pushed the develop branch 2 times, most recently from c8e5336 to 4fb877a Compare November 10, 2025 01:01
@networkfusion networkfusion force-pushed the develop branch 2 times, most recently from b4c081d to 490ddff Compare November 15, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant