Conversation
github-actions
Bot
added
kind:feature
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #define ADC_HW_REV_SENSE_CHANNEL /* PH4 */ ADC3_CH(15) | ||
|
|
||
| #define ADC_CHANNELS \ | ||
| ((1 << ADC_BATTERY_VOLTAGE_CHANNEL) | \ |
Contributor
There was a problem hiding this comment.
[error] bugprone-macro-parentheses [error]
macro replacement list should be enclosed in parentheses
Suggested change
| ((1 << ADC_BATTERY_VOLTAGE_CHANNEL) | \ | |
| (((1 << ADC_BATTERY_VOLTAGE_CHANNEL) | \ |
| (1 << ADC_SCALED_V5_CHANNEL) | \ | ||
| (1 << ADC_ADC3_6V6_CHANNEL) | \ | ||
| (1 << ADC_ADC3_3V3_CHANNEL)) | \ | ||
| (1 << ADC_SCALED_VDD_3V3_SENSORS1_CHANNEL) |
Contributor
There was a problem hiding this comment.
[error] bugprone-macro-parentheses [error]
macro replacement list should be enclosed in parentheses
Suggested change
| (1 << ADC_SCALED_VDD_3V3_SENSORS1_CHANNEL) | |
| (1 << ADC_SCALED_VDD_3V3_SENSORS1_CHANNEL)) |
Contributor
|
No broken links found in changed files. |
Corrected the link format for CyberX-v10 in the SUMMARY.md file.
| #define ADC_HW_REV_SENSE_CHANNEL /* PH4 */ ADC3_CH(15) | ||
|
|
||
| #define ADC_CHANNELS \ | ||
| ((1 << ADC_BATTERY_VOLTAGE_CHANNEL) | \ |
Contributor
There was a problem hiding this comment.
[error] bugprone-macro-parentheses [error]
macro replacement list should be enclosed in parentheses
Suggested change
| ((1 << ADC_BATTERY_VOLTAGE_CHANNEL) | \ | |
| (((1 << ADC_BATTERY_VOLTAGE_CHANNEL) | \ |
| (1 << ADC_SCALED_V5_CHANNEL) | \ | ||
| (1 << ADC_ADC3_6V6_CHANNEL) | \ | ||
| (1 << ADC_ADC3_3V3_CHANNEL)) | \ | ||
| (1 << ADC_SCALED_VDD_3V3_SENSORS1_CHANNEL) |
Contributor
There was a problem hiding this comment.
[error] bugprone-macro-parentheses [error]
macro replacement list should be enclosed in parentheses
Suggested change
| (1 << ADC_SCALED_VDD_3V3_SENSORS1_CHANNEL) | |
| (1 << ADC_SCALED_VDD_3V3_SENSORS1_CHANNEL)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear PX4-Autopilot Developer.
We have developed a flight controller, CyberX-v10, and will continue to develop it. Therefore, we hope to add our flight controller to support the hardware.
Board documentation
cyberx_v10.md
Board ID / USB identity
board ID: 5830, matching in PX4-Bootloader(merged)
USB VID: Currently, we are temporarily using the VID of ardupilot. The official VID from the manufacturer is currently being applied to the USB organization.We will apply for it as soon as possible and then add it in.
Flight log
It is still in test flight, and the flight log will be added later.
Best regard!